General UploadableResource collection factory tidy up

Author: silverbackdan

src/ApiPlatform/Metadata/Resource/UploadableResourceMetadataCollectionFactory.php

@@ -80,10 +80,12 @@ public function create(string $resourceClass): ResourceMetadataCollection
                 }
                 if ($operation instanceof Get) {
                     $uploadItemOperation = self::generateUploadItemOperation($operation, $openApiRequestMultipartProperties, $pathSegmentName);
-                    $operations->add(self::generateOperationName($uploadItemOperation), $uploadItemOperation);
+                    $uploadName = self::generateOperationName($uploadItemOperation);
+                    $operations->add($uploadName, $uploadItemOperation->withName($uploadName));
 
                     $downloadItemOperation = self::generateDownloadItemOperation($operation, $pathSegmentName);
-                    $operations->add(self::generateOperationName($downloadItemOperation), $downloadItemOperation);
+                    $downloadName = self::generateOperationName($downloadItemOperation);
+                    $operations->add($downloadName, $downloadItemOperation->withName($downloadName));
                 }
             }
         }
@@ -157,6 +159,8 @@ private static function generateDownloadItemOperation(Get $getOperation, string
             ->withUriTemplate($downloadPath)
             ->withStateless(null)
             ->withController(DownloadAction::class)
-            ->withSerialize(false);
+            ->withSerialize(false)
+            ->withShortName($getOperation->getShortName())
+            ->withRoutePrefix($getOperation->getRoutePrefix() ?? '');
     }
 }

tests/Functional/app/config/packages/api_platform.yaml

@@ -1,5 +1,6 @@
 api_platform:
     version: 1.0.0
+    mercure: ~
     mapping:
         paths:
             - '%kernel.project_dir%/../TestBundle/Entity'