Fix issue deleting a route when there are redirects pointing to it

Author: silverbackdan

features/bootstrap/DoctrineContext.php

@@ -494,6 +494,7 @@ public function thereIsARouteWithRedirects(string $firstPath, string $redirectTo
 
         $this->restContext->resources['final_route'] = $this->iriConverter->getIriFromResource($finalRoute);
         $this->restContext->resources['route'] = $this->iriConverter->getIriFromResource($route);
+        $this->restContext->resources['middle_route'] = $this->iriConverter->getIriFromResource($middleRoute);
         $this->restContext->resources['route_page'] = $this->iriConverter->getIriFromResource($page);
     }
 

features/main/route.feature

@@ -33,6 +33,15 @@ Feature: Route resources
     When I send a "DELETE" request to the resource "route"
     Then the response status code should be 204
 
+  @loginUser
+  Scenario: I can delete a route which has a redirect
+    Given there is a Route "/contact" which redirects to "/contact-new"
+    When I send a "DELETE" request to the resource "final_route"
+    Then the response status code should be 204
+    And the resource "final_route" should not exist
+    And the resource "route" should not exist
+    And the resource "middle_route" should not exist
+
   Scenario: A route will output the nested redirect routes and data for the redirected page
     Given there is a Route "/contact" which redirects to "/contact-new"
     When I send a "GET" request to "/_/routes//contact"

src/EventListener/Api/RouteEventListener.php

@@ -69,7 +69,7 @@ public function onPostWrite(ViewEvent $event): void
             throw new InvalidArgumentException(sprintf('Could not find entity manager for %s', $className));
         }
 
-        // create a redirect fro the old route
+        // create a redirect from the old route
         $previousRouteData = $request->attributes->get('previous_data');
         $previousPath = $previousRouteData->getPath();
         if ($previousPath !== $data->getPath()) {

src/Serializer/Normalizer/RouteNormalizer.php

@@ -40,6 +40,10 @@ public function normalize($object, $format = null, array $context = []): float|a
 
         $redirectedRoutes = [$finalRoute->getId()];
         while ($nextRedirect = $finalRoute->getRedirect()) {
+            // if a route has just been deleted which had other routes redirecting to it, then they will delete - but appear here as a redirect still without an ID for some reason
+            if (!$nextRedirect->getId()) {
+                break;
+            }
             if (\in_array($nextRedirect->getId(), $redirectedRoutes, true)) {
                 throw new CircularReferenceException(sprintf('The redirect routes result in a circular reference: %s', implode(' -> ', $redirectedRoutes)));
             }