CS Fixes

Author: silverbackdan

features/bootstrap/ProfilerContext.php

@@ -18,7 +18,6 @@
 use Behat\Mink\Exception\ExpectationException;
 use Behat\MinkExtension\Context\MinkContext;
 use PHPUnit\Framework\Assert;
-use Silverback\ApiComponentsBundle\Entity\Core\ComponentGroup;
 use Silverback\ApiComponentsBundle\Factory\User\Mailer\ChangeEmailConfirmationEmailFactory;
 use Silverback\ApiComponentsBundle\Factory\User\Mailer\PasswordChangedEmailFactory;
 use Silverback\ApiComponentsBundle\Factory\User\Mailer\PasswordResetEmailFactory;
@@ -76,6 +75,7 @@ private function getMercureMessageObjects(): array
 
     /**
      * @Then there should be :count mercure messages
+     *
      * @return Update[]
      */
     public function thereShouldBeAPublishedMercureUpdatePublished(?int $count = null)
@@ -107,7 +107,7 @@ private function getMercureComponentGroupMessage()
         foreach ($messageObjects as $messageObject) {
             $messageData = $messageObject->getData();
             $messageAsArray = $this->jsonContext->getJsonAsArray($messageData);
-            if($messageAsArray['@context'] === '/contexts/ComponentGroup') {
+            if ('/contexts/ComponentGroup' === $messageAsArray['@context']) {
                 return $messageAsArray;
             }
         }

src/ApiPlatform/Api/IriConverter.php

@@ -16,7 +16,6 @@
 use ApiPlatform\Api\IriConverterInterface;
 use ApiPlatform\Api\UrlGeneratorInterface;
 use ApiPlatform\Metadata\Operation;
-use Doctrine\ORM\EntityNotFoundException;
 use Silverback\ApiComponentsBundle\Entity\Core\Route;
 
 /**
@@ -33,13 +32,6 @@ public function getResourceFromIri(string $iri, array $context = [], ?Operation
         return $this->decorated->getResourceFromIri($iri, $context, $operation);
     }
 
-    /**
-     * @param $resource
-     * @param int $referenceType
-     * @param Operation|null $operation
-     * @param array $context
-     * @return string|null
-     */
     public function getIriFromResource($resource, int $referenceType = UrlGeneratorInterface::ABS_PATH, ?Operation $operation = null, array $context = []): ?string
     {
         if ($resource instanceof Route && ($path = $resource->getPath())) {

src/DataProvider/PageDataProvider.php

@@ -22,7 +22,6 @@
 use Doctrine\ORM\EntityManager;
 use Doctrine\Persistence\ManagerRegistry;
 use Silverback\ApiComponentsBundle\Entity\Core\AbstractPageData;
-use Silverback\ApiComponentsBundle\Entity\Core\ComponentInterface;
 use Silverback\ApiComponentsBundle\Metadata\PageDataComponentMetadata;
 use Silverback\ApiComponentsBundle\Metadata\PageDataPropertyMetadata;
 use Silverback\ApiComponentsBundle\Metadata\Provider\PageDataMetadataProvider;

src/DataProvider/StateProvider/RouteStateProvider.php

@@ -39,7 +39,7 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
         if ($operation instanceof CollectionOperationInterface) {
             return $this->defaultProvider->provide($operation->withProvider(CollectionProvider::class), $uriVariables, $context);
         }
-        
+
         $id = $uriVariables['id'];
         if (!\is_string($id)) {
             return $this->defaultProvider->provide($operation->withProvider(ItemProvider::class), $uriVariables, $context);

src/DependencyInjection/SilverbackApiComponentsExtension.php

@@ -245,7 +245,6 @@ private function loadServiceConfig(ContainerBuilder $container): void
         $loader->load('services.php');
         $loader->load('services_normalizers.php');
 
-
         $loader->load('services_doctrine_orm_http_cache_purger.php');
         $loader->load('services_doctrine_orm_mercure_publisher.php');
     }

src/EventListener/Doctrine/PropagateUpdatesListener.php

@@ -1,5 +1,16 @@
 <?php
 
+/*
+ * This file is part of the Silverback API Components Bundle Project
+ *
+ * (c) Daniel West <daniel@silverback.is>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
 namespace Silverback\ApiComponentsBundle\EventListener\Doctrine;
 
 use ApiPlatform\Api\IriConverterInterface;
@@ -8,19 +19,16 @@
 use ApiPlatform\Exception\InvalidArgumentException;
 use ApiPlatform\Metadata\GetCollection;
 use Doctrine\Common\Util\ClassUtils;
-use Doctrine\DBAL\Platforms\SqlitePlatform;
 use Doctrine\ORM\EntityRepository;
 use Doctrine\ORM\Event\OnFlushEventArgs;
 use Doctrine\ORM\Event\PostFlushEventArgs;
-use Doctrine\ORM\Event\PreFlushEventArgs;
 use Doctrine\ORM\PersistentCollection;
 use Doctrine\ORM\UnitOfWork;
 use Doctrine\Persistence\ManagerRegistry;
 use Doctrine\Persistence\ObjectManager;
 use Doctrine\Persistence\ObjectRepository;
 use Silverback\ApiComponentsBundle\DataProvider\PageDataProvider;
 use Silverback\ApiComponentsBundle\Entity\Component\Collection;
-use Silverback\ApiComponentsBundle\Entity\Core\Page;
 use Silverback\ApiComponentsBundle\Entity\Core\PageDataInterface;
 use Silverback\ApiComponentsBundle\HttpCache\ResourceChangedPropagatorInterface;
 use Silverback\ApiComponentsBundle\Repository\Core\ComponentPositionRepository;
@@ -36,12 +44,7 @@ class PropagateUpdatesListener
     private array $updatedCollectionClassToIriMapping = [];
 
     /**
-     * @param IriConverterInterface $iriConverter
-     * @param ManagerRegistry $entityManager
      * @param iterable|ResourceChangedPropagatorInterface[] $resourceChangedPropagators
-     * @param ResourceClassResolverInterface $resourceClassResolver
-     * @param PageDataProvider $pageDataProvider
-     * @param ComponentPositionRepository $positionRepository
      */
     public function __construct(
         private readonly IriConverterInterface $iriConverter,
@@ -90,7 +93,7 @@ private function collectUpdatedPageDataAndPositions(): void
             $pageDataComponentMetadata = $this->pageDataProvider->findPageDataComponentMetadata($updatedResource);
             foreach ($pageDataComponentMetadata as $pageDataComponentMetadatum) {
                 $pageDataResources = $pageDataComponentMetadatum->getPageDataResources();
-                if (count($pageDataResources)) {
+                if (\count($pageDataResources)) {
                     foreach ($pageDataResources as $pageDataResource) {
                         $this->collectUpdatedResource($pageDataResource, 'updated');
                         $this->addToPropagators($pageDataResource, 'updated');
@@ -191,7 +194,7 @@ private function addResourceIrisFromObject($resource, string $type): void
     {
         if (
             isset($this->updatedResources[$resource]) &&
-            $type !== 'deleted'
+            'deleted' !== $type
         ) {
             return;
         }
@@ -226,7 +229,7 @@ private function collectDynamicComponentPositionResources(array $pageDataPropert
         if (!$pageDataPropertiesChanged) {
             $pageDataPropertiesChanged = $this->pageDataPropertiesChanged;
         }
-        if (0 === count($pageDataPropertiesChanged)) {
+        if (0 === \count($pageDataPropertiesChanged)) {
             return;
         }
         $positions = $this->positionRepository->findByPageDataProperties($pageDataPropertiesChanged);

src/EventListener/Doctrine/SqlLiteForeignKeyEnabler.php

@@ -1,5 +1,16 @@
 <?php
 
+/*
+ * This file is part of the Silverback API Components Bundle Project
+ *
+ * (c) Daniel West <daniel@silverback.is>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
 namespace Silverback\ApiComponentsBundle\EventListener\Doctrine;
 
 use Doctrine\DBAL\Platforms\SqlitePlatform;

src/Mercure/MercureResourcePublisher.php

@@ -25,7 +25,6 @@
 use ApiPlatform\Serializer\SerializerContextBuilderInterface;
 use ApiPlatform\Symfony\Messenger\DispatchTrait;
 use ApiPlatform\Util\ResourceClassInfoTrait;
-use Doctrine\ORM\EntityNotFoundException;
 use Doctrine\ORM\PersistentCollection;
 use Silverback\ApiComponentsBundle\HttpCache\ResourceChangedPropagatorInterface;
 use Symfony\Component\ExpressionLanguage\ExpressionFunction;

src/Resources/config/services.php

@@ -1389,8 +1389,7 @@
 
     $services
         ->set(SqlLiteForeignKeyEnabler::class)
-        ->tag('doctrine.event_listener', ['event' => DoctrineEvents::preFlush])
-    ;
+        ->tag('doctrine.event_listener', ['event' => DoctrineEvents::preFlush]);
 
     $services
         ->set('silverback.api_components.event_listener.doctrine.propagate_updates_listener')
@@ -1401,7 +1400,7 @@
             new TaggedIteratorArgument('silverback_api_components.resource_changed_propagator'),
             new Reference('api_platform.resource_class_resolver'),
             new Reference(PageDataProvider::class),
-            new Reference('silverback.doctrine.repository.component_position')
+            new Reference('silverback.doctrine.repository.component_position'),
         ])
         ->tag('doctrine.event_listener', ['event' => DoctrineEvents::onFlush])
         ->tag('doctrine.event_listener', ['event' => DoctrineEvents::postFlush]);