diff --git a/CHANGES.rst b/CHANGES.rst index aaf5f1a..d984530 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -5,8 +5,8 @@ Changelog 1.1 (unreleased) ---------------- -- Nothing changed yet. - +- Add default width and heigth attributes if none provided when using the srcset method + [erral] 1.0 (2025-09-24) ---------------- diff --git a/src/cs/srcset/tests/test_view.py b/src/cs/srcset/tests/test_view.py index f8f7d8b..477b8cf 100644 --- a/src/cs/srcset/tests/test_view.py +++ b/src/cs/srcset/tests/test_view.py @@ -83,7 +83,7 @@ def testImgSrcSet(self): } tag = self.scaling.srcset("image", sizes="50vw") base = self.item.absolute_url() - expected = f"""foo""" + expected = f"""foo""" self.assertTrue(_ellipsis_match(expected, tag.strip())) def testImgSrcSetCustomSrc(self): @@ -103,7 +103,7 @@ def testImgSrcSetCustomSrc(self): } tag = self.scaling.srcset("image", sizes="50vw", scale_in_src="mini") base = self.item.absolute_url() - expected = f"""foo""" + expected = f"""foo""" self.assertTrue(_ellipsis_match(expected, tag.strip())) def testImgSrcSetInexistentScale(self): @@ -127,7 +127,7 @@ def testImgSrcSetInexistentScale(self): "image", sizes="50vw", scale_in_src="inexistent-scale-name" ) base = self.item.absolute_url() - expected = f"""foo""" + expected = f"""foo""" self.assertTrue(_ellipsis_match(expected, tag.strip())) def testImgSrcSetCustomTitle(self): @@ -147,7 +147,7 @@ def testImgSrcSetCustomTitle(self): } tag = self.scaling.srcset("image", sizes="50vw", title="My Custom Title") base = self.item.absolute_url() - expected = f"""foo""" + expected = f"""foo""" self.assertTrue(_ellipsis_match(expected, tag.strip())) def testImgSrcSetAdditionalAttributes(self): @@ -175,5 +175,5 @@ def testImgSrcSetAdditionalAttributes(self): ) base = self.item.absolute_url() - expected = f"""This image shows nothing""" + expected = f"""This image shows nothing""" self.assertTrue(_ellipsis_match(expected, tag.strip())) diff --git a/src/cs/srcset/view.py b/src/cs/srcset/view.py index 21866d8..c7a5440 100644 --- a/src/cs/srcset/view.py +++ b/src/cs/srcset/view.py @@ -224,5 +224,9 @@ def srcset( scale = self.scale(fieldname=fieldname, scale=scale_in_src) attributes["src"] = scale.url + if "width" not in attributes: + attributes["width"] = scale.width + if "height" not in attributes: + attributes["height"] = scale.height return _image_tag_from_values(*attributes.items())