don't require 'id' field in rdesc/cdesc for subset.gct

[tnat1031]

[tnat1031]

subset.gct currently fails if either rdesc or cdesc doesn't have an 'id' column

[dllahr]

Not sure how the structures work in R, but in python / pandas cdesc/rdesc have to have an index the corresponds to the ID (and matches the data dataframe). Matlab in purely positional - the cid/rid is not present in cdesc/rdesc. I don't know what makes most sense for R, but I would pick one of these models and stick with it - e.g. you make it mandatory that cdesc/rdesc contains and ID column or you make it so it doesn't but the positions are the identifier, but you probably shouldn't do both.

…

On Fri, Jan 5, 2018 at 5:09 PM, Ted Natoli ***@***.***> wrote: subset.gct currently fails if either rdesc or cdesc doesn't have an 'id' column — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABfjInZ6evkKcDSXatUT_jt9y1tZGBrkks5tHp2WgaJpZM4RVAfD> .

-- 617 714 7868 dlahr@broadinstitute.org