From 647d23372b4dfdd2a0e5593667a03d8c5486703e Mon Sep 17 00:00:00 2001 From: Jop Zinkweg Date: Mon, 22 Dec 2025 13:03:40 +0100 Subject: [PATCH] Log warning if java_opts.yml parsing fails Finalize() is not called when java_opts detection fails, yaml parse failures should not be hidden as Debug data. --- src/java/frameworks/java_opts.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/java/frameworks/java_opts.go b/src/java/frameworks/java_opts.go index 80db3f440..be24b16b9 100644 --- a/src/java/frameworks/java_opts.go +++ b/src/java/frameworks/java_opts.go @@ -26,12 +26,13 @@ func NewJavaOptsFramework(ctx *common.Context) *JavaOptsFramework { return &JavaOptsFramework{context: ctx} } -// Detect always returns true (universal framework for JAVA_OPTS configuration) +// Detect returns a positive result if loadConfig() finds settings (universal framework for JAVA_OPTS configuration) func (j *JavaOptsFramework) Detect() (string, error) { // Check if there's any configuration to apply config, err := j.loadConfig() if err != nil { - j.context.Log.Debug("Failed to load java_opts config: %s", err.Error()) + // if detect "fails" Finalize() is not called so log parse failures as warning + j.context.Log.Warning("Failed to load java_opts config: %s", err.Error()) return "", nil }