Error handling for client/server call mismatches (#25)

* Add error handling for when the user requests a call from cdpy that is not available in the installed CDPCLI
* Add error handling for when CDPCLI makes a call that is not available in the remote CDP Control Plane
* Move Custom Error handling functionality into the CdpError class and out of call()
* Directly Handle parsing AttributeError and ValidationError into common format
* Move Handling REMOTE_NOT_IMPLMENTED in CdpError

Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>

Author: Chaffelson

src/cdpy/common.py

@@ -20,7 +20,7 @@
 from cdpcli.client import ClientCreator, Context
 from cdpcli.credentials import Credentials
 from cdpcli.endpoint import EndpointCreator, EndpointResolver
-from cdpcli.exceptions import ClientError, ParamValidationError
+from cdpcli.exceptions import ClientError, ParamValidationError, ValidationError
 from cdpcli.loader import Loader
 from cdpcli.parser import ResponseParserFactory
 from cdpcli.retryhandler import create_retry_handler
@@ -47,6 +47,20 @@ def __init__(self, base_error, *args):
         self.operation = None
         self.request_id = None
 
+        if isinstance(self.base_error, AttributeError):
+            self.rc = 1
+            self.status_code = '404'
+            self.error_code = "LOCAL_NOT_IMPLEMENTED"
+            self.violations = self.message = str(self.base_error) + ". The installed CDPCLI does not support this call."
+
+        if isinstance(self.base_error, ValidationError):
+            self.message = self.violations = str(self.base_error) + ". The installed CDPCLI does not support this call."
+            self.rc = 1
+            self.status_code = '404'
+            self.operation = self.base_error.kwargs['param']
+            self.service = self.base_error.kwargs['value']
+            self.error_code = 'LOCAL_NOT_IMPLEMENTED'
+
         if isinstance(self.base_error, ClientError):
             _CLIENT_ERROR_PATTERN = re.compile(
                 r"Status Code: (.*?); Error Code: (.*?); Service: "
@@ -82,6 +96,16 @@ def __init__(self, base_error, *args):
             self.message = "Parameter validation error"
             self.error_code = 'PARAMETER_VALIDATION_ERROR'
 
+        # Handle instance where client calls function not found in remote CDP Control Plane
+        if self.status_code == '404' \
+                and self.error_code == 'UNKNOWN_ERROR' \
+                and 'HTTP ERROR 404 Not Found' in self.message:
+            self.error_code = "REMOTE_NOT_IMPLEMENTED"
+            self.violations = "Function {0} in Remote Service {1} was not found. " \
+                              "Your connected CDP Control Plane may not support this call. " \
+                              "Rerun this call with strict_errors enabled to get full traceback." \
+                              .format(self.operation, self.service)
+
         super().__init__(base_error, *args)
 
     def update(self, *args, **kwargs):
@@ -515,12 +539,13 @@ def call(self, svc: str, func: str, ret_field: str = None, squelch: ['Squelch']
                 parsed_err.update(sdk_out=log, sdk_out_lines=log.splitlines())
             if self.strict_errors is True:
                 self.throw_error(parsed_err)
-            if isinstance(err, ClientError) and squelch is not None:
-                for item in squelch:
-                    if item.value in str(parsed_err.__getattribute__(item.field)):
-                        warning = item.warning if item.warning is not None else str(parsed_err.violations)
-                        self.throw_warning(CdpWarning(warning))
-                        return item.default
+            if isinstance(err, ClientError):
+                if squelch is not None:
+                    for item in squelch:
+                        if item.value in str(parsed_err.__getattribute__(item.field)):
+                            warning = item.warning if item.warning is not None else str(parsed_err.violations)
+                            self.throw_warning(CdpWarning(warning))
+                            return item.default
             if ret_error is True:
                 return parsed_err
             self.throw_error(parsed_err)