Skip to content

Commit a89118b

Browse files
authored
Merge pull request #180 from hapytex/improvement/modern-paths
Modern paths
2 parents da86f4e + 9fb398f commit a89118b

File tree

3 files changed

+20
-21
lines changed

3 files changed

+20
-21
lines changed

cbv/shortcut_urls.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
from django.urls import re_path
1+
from django.urls import path
22

33
from cbv import views
44

55

66
urlpatterns = [
7-
re_path(
8-
r"(?P<klass>[a-zA-Z_-]+)/$",
7+
path(
8+
"<str:klass>/",
99
views.LatestKlassDetailView.as_view(),
1010
name="klass-detail-shortcut",
1111
),

cbv/urls.py

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -10,52 +10,51 @@
1010
django/1.41a
1111
django/1.41a/core
1212
django/1.41a/core/DjangoRuntimeWarning
13-
1413
"""
1514

16-
from django.urls import path, re_path, reverse_lazy
15+
from django.urls import path, reverse_lazy
1716
from django.views.generic import RedirectView
1817

1918
from cbv import views
2019

2120

2221
urlpatterns = [
2322
path("", RedirectView.as_view(url=reverse_lazy("home"))),
24-
re_path(
25-
r"^(?P<package>[\w-]+)/$",
23+
path(
24+
"<slug:package>/",
2625
views.RedirectToLatestVersionView.as_view(),
2726
{"url_name": "version-detail"},
2827
),
29-
re_path(
30-
r"^(?P<package>[\w-]+)/latest/$",
28+
path(
29+
"<slug:package>/latest/",
3130
views.RedirectToLatestVersionView.as_view(),
3231
{"url_name": "version-detail"},
3332
name="latest-version-detail",
3433
),
35-
re_path(
36-
r"^(?P<package>[\w-]+)/(?P<version>[^/]+)/$",
34+
path(
35+
"<slug:package>/<str:version>/",
3736
views.VersionDetailView.as_view(),
3837
name="version-detail",
3938
),
40-
re_path(
41-
r"^(?P<package>[\w-]+)/latest/(?P<module>[\w\.]+)/$",
39+
path(
40+
"<slug:package>/latest/<str:module>/",
4241
views.RedirectToLatestVersionView.as_view(),
4342
{"url_name": "module-detail"},
4443
name="latest-module-detail",
4544
),
46-
re_path(
47-
r"^(?P<package>[\w-]+)/(?P<version>[^/]+)/(?P<module>[\w\.]+)/$",
45+
path(
46+
"<slug:package>/<str:version>/<str:module>/",
4847
views.ModuleDetailView.as_view(),
4948
name="module-detail",
5049
),
51-
re_path(
52-
r"^(?P<package>[\w-]+)/latest/(?P<module>[\w\.]+)/(?P<klass>[\w]+)/$",
50+
path(
51+
"<slug:package>/latest/<str:module>/<str:klass>/",
5352
views.RedirectToLatestVersionView.as_view(),
5453
{"url_name": "klass-detail"},
5554
name="latest-klass-detail",
5655
),
57-
re_path(
58-
r"^(?P<package>[\w-]+)/(?P<version>[^/]+)/(?P<module>[\w\.]+)/(?P<klass>[\w]+)/$",
56+
path(
57+
"<slug:package>/<str:version>/<str:module>/<str:klass>/",
5958
views.KlassDetailView.as_view(),
6059
name="klass-detail",
6160
),

inspector/urls.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from django.conf import settings
22
from django.conf.urls.static import static
3-
from django.urls import include, path, re_path
3+
from django.urls import include, path
44
from django.views.generic import TemplateView
55

66
from cbv.views import HomeView, Sitemap
@@ -9,7 +9,7 @@
99
urlpatterns = [
1010
path("", HomeView.as_view(), name="home"),
1111
path("projects/", include("cbv.urls")),
12-
re_path(r"^sitemap\.xml$", Sitemap.as_view(), name="sitemap"),
12+
path("sitemap.xml", Sitemap.as_view(), name="sitemap"),
1313
path("", include("cbv.shortcut_urls"), {"package": "Django"}),
1414
] + static(settings.STATIC_URL, document_root=settings.STATIC_ROOT)
1515

0 commit comments

Comments
 (0)