Do not mark IBM J9 scavenge as full gc

Scavenge operation only affects young gen.
See description of tag '<gc-start>' attribute 'type' value 'scavenge' at
https://www.ibm.com/support/knowledgecenter/SSYKE2_8.0.0/com.ibm.java.vm.80.doc/docs/mm_gc_pd_verbose_increment.html

Author: Christian Mötzing

src/main/java/com/tagtraum/perf/gcviewer/imp/DataReaderIBM_J9_R28.java

@@ -216,10 +216,13 @@ else if (startEl.getName().getLocalPart().equals("mem")) {
                             event.add(young);
                             break;
                         case "tenure":
-                            GCEvent tenured = new GCEvent();
-                            tenured.setType(Type.lookup("tenure"));
-                            setTotalAndPreUsed(tenured, startEl);
-                            event.add(tenured);
+                            // scavenge prints tenure space but does not change it as it is young only
+                            if(!typeName.contains("scavenge")) {
+                                GCEvent tenured = new GCEvent();
+                                tenured.setType(Type.lookup("tenure"));
+                                setTotalAndPreUsed(tenured, startEl);
+                                event.add(tenured);
+                            }
                             break;
                         // all other are ignored
                     }
@@ -247,7 +250,10 @@ else if (startEl.getName().getLocalPart().equals("mem")) {
                             setPostUsed(event.getYoung(), startEl);
                             break;
                         case "tenure":
-                            setPostUsed(event.getTenured(), startEl);
+                            // scavenge prints tenure space but does not change it as it is young only
+                            if(!event.getTypeAsString().contains("scavenge")) {
+                                setPostUsed(event.getTenured(), startEl);
+                            }
                             break;
                         // all other are ignored
                     }

src/main/java/com/tagtraum/perf/gcviewer/model/AbstractGCEvent.java

@@ -709,9 +709,10 @@ public String toString() {
         public static final Type UJL_ZGC_HEAP_CAPACITY = new Type("Capacity", Generation.TENURED, Concurrency.SERIAL, GcPattern.GC_HEAP_MEMORY_PERCENTAGE);
 
         // IBM Types
-        // TODO: are scavenge always young only??
-        public static final Type IBM_AF = new Type("af", Generation.YOUNG);
         public static final Type IBM_SYS = new Type("sys explicit", Generation.ALL);
+        public static final Type IBM_AF = new Type("af", Generation.YOUNG);
+        // scavenge is young only
+        // see  https://www.ibm.com/support/knowledgecenter/SSYKE2_8.0.0/com.ibm.java.vm.80.doc/docs/mm_gc_pd_verbose_increment.html
         public static final Type IBM_AF_SCAVENGE = new Type("af scavenge", Generation.YOUNG);
         public static final Type IBM_AF_GLOBAL = new Type("af global", Generation.TENURED);
         public static final Type IBM_SYS_GLOBAL = new Type("sys global", Generation.ALL);

src/test/java/com/tagtraum/perf/gcviewer/imp/TestDataReaderIBM_J9_R28.java

@@ -12,10 +12,7 @@
 
 import com.tagtraum.perf.gcviewer.UnittestHelper;
 import com.tagtraum.perf.gcviewer.UnittestHelper.FOLDER;
-import com.tagtraum.perf.gcviewer.model.GCEvent;
-import com.tagtraum.perf.gcviewer.model.GCModel;
-import com.tagtraum.perf.gcviewer.model.GCResource;
-import com.tagtraum.perf.gcviewer.model.GcResourceFile;
+import com.tagtraum.perf.gcviewer.model.*;
 import org.junit.Test;
 
 /**
@@ -62,8 +59,9 @@ public void testAfScavenge() throws Exception {
         assertThat("timestamp 1", event.getTimestamp(), closeTo(0.0, 0.0001));
         assertThat("timestamp 2", model.get(1).getTimestamp(), closeTo(1.272, 0.0001));
 
-        assertThat("type", event.getTypeAsString(), equalTo("af scavenge; nursery; tenure"));
-
+        assertThat("type", event.getTypeAsString(), equalTo("af scavenge; nursery"));
+        assertThat("generation", event.getExtendedType().getGeneration(), is(AbstractGCEvent.Generation.YOUNG));
+        assertThat("full", event.isFull(), is(false));
         assertThat("number of errors", handler.getCount(), is(0));
     }
 
@@ -130,9 +128,13 @@ public void testConcurrentCollection() throws Exception {
         DataReader reader = getDataReader(gcResource);
         GCModel model = reader.read();
 
+        AbstractGCEvent<?> event = model.get(0);
         assertThat("model size", model.size(), is(1));
-        assertThat("duration", model.get(0).getPause(), closeTo(1.182375, 0.00000001));
+        assertThat("duration", event.getPause(), closeTo(1.182375, 0.00000001));
         assertThat("number of errors", handler.getCount(), is(0));
+
+        assertThat("", event.getExtendedType().getConcurrency(), is(AbstractGCEvent.Concurrency.CONCURRENT));
+        assertThat("", event.getExtendedType().getGeneration(), is(AbstractGCEvent.Generation.ALL));
     }
 
 }