Merge pull request #1998 from craigcomstock/local-lint

Refactored shellcheck workflow to be ci/lint.sh and lint.yml workflow

Author: olehermanse

.github/workflows/shellcheck.yml .github/workflows/lint.yml.github/workflows/shellcheck.yml renamed to .github/workflows/lint.yml

@@ -18,7 +18,4 @@ jobs:
         run: sudo apt install shellcheck
       - name: Lint sources with shellcheck
         run: |
-          # Recursively find all shell scripts in the build-scripts directory with a shebang
-          grep -Erl '^(#!/(bin|usr/bin)/(env )?(sh|bash))' build-scripts/ | while read -r file; do
-              shellcheck --external-sources --source-path=build-scripts "$file"
-          done
+          ./ci/lint.sh

ci/lint.sh

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+shellcheck_dirs() {
+  grep -Erl '^(#!/(bin|usr/bin)/(env )?(sh|bash))' "$1" | while read -r file; do
+      shellcheck --external-sources --source-path=build-scripts "$file"
+  done
+}
+
+shellcheck_dirs build-scripts/
+
+# some dirs are "dirty" aka need some work so don't fail on those yet
+shellcheck_dirs ci/ packaging/ || true