$Cart->conditions('type', true) does not return item-level conditions

[travisulrich]

$cart->conditions(null) includes items, but $cart->conditions(‘type’) does not.

TestCase:

    public function test_item_level_conditions_are_returned()
    {
        $product = FactoryMuffin::create('Acme\Models\Product', ['title'=>'A New Product']);
        $coupon = $this->createCondition('Test Coupon', 'coupon', '5', 'subtotal');
        $discount = $this->createCondition('Test Discount', 'discount', '10%', 'subtotal');
        $this->cart->add($this->createItemFromProduct($product, 1, 10, [$coupon, $discount]));
        $this->assertEquals(2, count($this->cart->conditions()));

        //The following assertion fails with: Failed asserting that 0 matches expected 1.
        $this->assertEquals(1, count($this->cart->conditions('coupon')));
    }

This test passes after updating the $cart->conditions() method to the following:

    public function conditions($type = null, $includeItems = true)
    {
        $conditions = [];

        if ( ! $type) {
            if ($includeItems) {
                foreach ($this->items as $item) {
                    $conditions = array_merge($conditions, $item->conditions());
                }
            }

            return array_merge($conditions, $this->conditions);
        }

        if ($includeItems) {
            foreach ($this->items as $item) {
                $conditions = array_merge($conditions, $item->conditions($type));
            }
        }
        foreach ($this->conditions as $condition) {
            if ($condition->get('type') === $type) {
                $conditions[] = $condition;
            }
        }

        return $conditions;
    }

[brunogaspar]

@travisulrich Thanks for the report.

Can you send a PR to the 1.0 branch? I believe this is still the same on that branch.

[travisulrich]

Dug into this a little more today, and it looks like part of the issue is that BaseCollection->conditions() (do not include items) has a different behavior and signature than CartCollection->conditions() (include items by default).
When applyCondition() is called from the CartCollection class, it should be iterating over $this->conditions($conditionType, false) but in BaseCollection->applyCondition() it should be $this->conditions($conditionType)
When #55 was applied, at least some of the errors were caused by the fact that cart conditions were being applied to both the Cart as well as each item.

[brunogaspar]

Fixing this will most likely introduce a breaking change, as it was introduced by your PR and it would require us to do a new major release to really fix this.

We don't have any ETA of if and when we'll do a new major release of this package.

[travisulrich]

Ok, I'll try to work around it until the next major version comes along