diff --git a/.gitattributes b/.gitattributes index 33d633cb..79dc7a2f 100644 --- a/.gitattributes +++ b/.gitattributes @@ -19,3 +19,5 @@ phpunit.xml.dist export-ignore /CakePHP/Tests export-ignore phpstan.neon export-ignore .phive export-ignore +/tests export-ignore +/docs export-ignore diff --git a/.gitignore b/.gitignore index c562cb42..aab618e2 100644 --- a/.gitignore +++ b/.gitignore @@ -5,3 +5,4 @@ composer.lock vendor/ /.idea/ /tools/ +/.phpunit.cache/ diff --git a/CakePHP/Sniffs/NamingConventions/ValidFunctionNameSniff.php b/CakePHP/Sniffs/NamingConventions/ValidFunctionNameSniff.php index c7dd3c03..65037bf7 100644 --- a/CakePHP/Sniffs/NamingConventions/ValidFunctionNameSniff.php +++ b/CakePHP/Sniffs/NamingConventions/ValidFunctionNameSniff.php @@ -63,7 +63,7 @@ public function __construct() protected function processTokenWithinScope(File $phpcsFile, $stackPtr, $currScope) { $methodName = $phpcsFile->getDeclarationName($stackPtr); - if ($methodName === null) { + if ($methodName === '') { return; } diff --git a/CakePHP/Tests/Classes/ReturnTypeHintUnitTest.php b/CakePHP/Tests/Classes/ReturnTypeHintUnitTest.php index 48c816b5..e62f829d 100644 --- a/CakePHP/Tests/Classes/ReturnTypeHintUnitTest.php +++ b/CakePHP/Tests/Classes/ReturnTypeHintUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\Classes; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class ReturnTypeHintUnitTest extends AbstractSniffUnitTest +class ReturnTypeHintUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/Commenting/DocBlockAlignmentUnitTest.php b/CakePHP/Tests/Commenting/DocBlockAlignmentUnitTest.php index 552399d4..f25b0c15 100644 --- a/CakePHP/Tests/Commenting/DocBlockAlignmentUnitTest.php +++ b/CakePHP/Tests/Commenting/DocBlockAlignmentUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\Commenting; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class DocBlockAlignmentUnitTest extends AbstractSniffUnitTest +class DocBlockAlignmentUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/Commenting/FunctionCommentUnitTest.php b/CakePHP/Tests/Commenting/FunctionCommentUnitTest.php index 314918a4..ec952739 100644 --- a/CakePHP/Tests/Commenting/FunctionCommentUnitTest.php +++ b/CakePHP/Tests/Commenting/FunctionCommentUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\Commenting; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class FunctionCommentUnitTest extends AbstractSniffUnitTest +class FunctionCommentUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/Commenting/InheritDocUnitTest.php b/CakePHP/Tests/Commenting/InheritDocUnitTest.php index 4ba824cb..b9dd94dc 100644 --- a/CakePHP/Tests/Commenting/InheritDocUnitTest.php +++ b/CakePHP/Tests/Commenting/InheritDocUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\Commenting; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class InheritDocUnitTest extends AbstractSniffUnitTest +class InheritDocUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/Commenting/TypeHintUnitTest.php b/CakePHP/Tests/Commenting/TypeHintUnitTest.php index 0cdd01e8..e39db3fa 100644 --- a/CakePHP/Tests/Commenting/TypeHintUnitTest.php +++ b/CakePHP/Tests/Commenting/TypeHintUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\Commenting; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class TypeHintUnitTest extends AbstractSniffUnitTest +class TypeHintUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/ControlStructures/ControlStructuresUnitTest.php b/CakePHP/Tests/ControlStructures/ControlStructuresUnitTest.php index 7ff93440..f3a6b5db 100644 --- a/CakePHP/Tests/ControlStructures/ControlStructuresUnitTest.php +++ b/CakePHP/Tests/ControlStructures/ControlStructuresUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\ControlStructures; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class ControlStructuresUnitTest extends AbstractSniffUnitTest +class ControlStructuresUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/ControlStructures/ElseIfDeclarationUnitTest.php b/CakePHP/Tests/ControlStructures/ElseIfDeclarationUnitTest.php index 1ff4198a..867fd80a 100644 --- a/CakePHP/Tests/ControlStructures/ElseIfDeclarationUnitTest.php +++ b/CakePHP/Tests/ControlStructures/ElseIfDeclarationUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\ControlStructures; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class ElseIfDeclarationUnitTest extends AbstractSniffUnitTest +class ElseIfDeclarationUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/ControlStructures/WhileStructuresUnitTest.php b/CakePHP/Tests/ControlStructures/WhileStructuresUnitTest.php index c3eb37b9..f0cff368 100644 --- a/CakePHP/Tests/ControlStructures/WhileStructuresUnitTest.php +++ b/CakePHP/Tests/ControlStructures/WhileStructuresUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\ControlStructures; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class WhileStructuresUnitTest extends AbstractSniffUnitTest +class WhileStructuresUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/Formatting/BlankLineBeforeReturnUnitTest.php b/CakePHP/Tests/Formatting/BlankLineBeforeReturnUnitTest.php index 9b1f8ea6..f4e5182c 100644 --- a/CakePHP/Tests/Formatting/BlankLineBeforeReturnUnitTest.php +++ b/CakePHP/Tests/Formatting/BlankLineBeforeReturnUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\Formatting; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class BlankLineBeforeReturnUnitTest extends AbstractSniffUnitTest +class BlankLineBeforeReturnUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/NamingConventions/ValidFunctionNameUnitTest.php b/CakePHP/Tests/NamingConventions/ValidFunctionNameUnitTest.php index 76d82563..2816783a 100644 --- a/CakePHP/Tests/NamingConventions/ValidFunctionNameUnitTest.php +++ b/CakePHP/Tests/NamingConventions/ValidFunctionNameUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\NamingConventions; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class ValidFunctionNameUnitTest extends AbstractSniffUnitTest +class ValidFunctionNameUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/NamingConventions/ValidTraitNameUnitTest.php b/CakePHP/Tests/NamingConventions/ValidTraitNameUnitTest.php index 593f2c92..2f652479 100644 --- a/CakePHP/Tests/NamingConventions/ValidTraitNameUnitTest.php +++ b/CakePHP/Tests/NamingConventions/ValidTraitNameUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\NamingConventions; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class ValidTraitNameUnitTest extends AbstractSniffUnitTest +class ValidTraitNameUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/PHP/DisallowShortOpenTagUnitTest.php b/CakePHP/Tests/PHP/DisallowShortOpenTagUnitTest.php index 4a815a20..cc43fd28 100644 --- a/CakePHP/Tests/PHP/DisallowShortOpenTagUnitTest.php +++ b/CakePHP/Tests/PHP/DisallowShortOpenTagUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\PHP; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class DisallowShortOpenTagUnitTest extends AbstractSniffUnitTest +class DisallowShortOpenTagUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/WhiteSpace/EmptyLinesUnitTest.php b/CakePHP/Tests/WhiteSpace/EmptyLinesUnitTest.php index b8d335e7..b53985f6 100644 --- a/CakePHP/Tests/WhiteSpace/EmptyLinesUnitTest.php +++ b/CakePHP/Tests/WhiteSpace/EmptyLinesUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\WhiteSpace; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class EmptyLinesUnitTest extends AbstractSniffUnitTest +class EmptyLinesUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/WhiteSpace/FunctionCallSpacingUnitTest.php b/CakePHP/Tests/WhiteSpace/FunctionCallSpacingUnitTest.php index 2bcbb5de..b0d7da5f 100644 --- a/CakePHP/Tests/WhiteSpace/FunctionCallSpacingUnitTest.php +++ b/CakePHP/Tests/WhiteSpace/FunctionCallSpacingUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\WhiteSpace; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class FunctionCallSpacingUnitTest extends AbstractSniffUnitTest +class FunctionCallSpacingUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/WhiteSpace/FunctionClosingBraceSpaceUnitTest.php b/CakePHP/Tests/WhiteSpace/FunctionClosingBraceSpaceUnitTest.php index c1a0baa2..d75a7c72 100644 --- a/CakePHP/Tests/WhiteSpace/FunctionClosingBraceSpaceUnitTest.php +++ b/CakePHP/Tests/WhiteSpace/FunctionClosingBraceSpaceUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\WhiteSpace; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class FunctionClosingBraceSpaceUnitTest extends AbstractSniffUnitTest +class FunctionClosingBraceSpaceUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/WhiteSpace/FunctionOpeningBraceSpaceUnitTest.php b/CakePHP/Tests/WhiteSpace/FunctionOpeningBraceSpaceUnitTest.php index d6519bc2..431a462f 100644 --- a/CakePHP/Tests/WhiteSpace/FunctionOpeningBraceSpaceUnitTest.php +++ b/CakePHP/Tests/WhiteSpace/FunctionOpeningBraceSpaceUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\WhiteSpace; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class FunctionOpeningBraceSpaceUnitTest extends AbstractSniffUnitTest +class FunctionOpeningBraceSpaceUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/Tests/WhiteSpace/TabAndSpaceUnitTest.php b/CakePHP/Tests/WhiteSpace/TabAndSpaceUnitTest.php index 361ed680..1f6c28df 100644 --- a/CakePHP/Tests/WhiteSpace/TabAndSpaceUnitTest.php +++ b/CakePHP/Tests/WhiteSpace/TabAndSpaceUnitTest.php @@ -2,9 +2,9 @@ namespace CakePHP\Tests\WhiteSpace; -use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest; +use PHP_CodeSniffer\Tests\Standards\AbstractSniffTestCase; -class TabAndSpaceUnitTest extends AbstractSniffUnitTest +class TabAndSpaceUnitTest extends AbstractSniffTestCase { /** * @inheritDoc diff --git a/CakePHP/ruleset.xml b/CakePHP/ruleset.xml index b20fa1a0..f41ec35f 100644 --- a/CakePHP/ruleset.xml +++ b/CakePHP/ruleset.xml @@ -1,17 +1,22 @@ - + CakePHP coding standard - - \.git /*/tmp/ tests/*/templates/* - + + + +