refactor: fix types, switch cases

Author: borodayev

src/definitions.js

@@ -5,14 +5,17 @@ import type { ObjectId, MongooseModel, MongooseDocument } from 'mongoose';
 import MHD, { revertChanges } from './diff';
 
 export type OptionsT = {|
-  diffCollectionName: ?string,
-  orderIndependent: ?boolean,
+  diffCollectionName?: string,
+  orderIndependent?: boolean,
 |};
 
-export type DiffModelT = MongooseModel & typeof DiffDoc;
-
 export type KindT = 'E' | 'N' | 'D' | 'A';
 
+export class ItemDoc /* :: extends Mongoose$Document */ {
+  k: KindT;
+  l: ?any;
+  r: ?any;
+}
 export type RawChangeT = {|
   k: KindT,
   p: Array<string>,
@@ -22,12 +25,6 @@ export type RawChangeT = {|
   it?: $Shape<ItemDoc>,
 |};
 
-export class ItemDoc /* :: extends Mongoose$Document */ {
-  k: KindT;
-  l: ?any;
-  r: ?any;
-}
-
 export class ChangeDoc /* :: extends Mongoose$Document */ {
   k: KindT;
   p: Array<string>;
@@ -82,3 +79,5 @@ export class DiffDoc /* :: extends Mongoose$Document */ {
     return MHD.findDiff(initialDoc, currentDoc);
   }
 }
+
+export type DiffModelT = MongooseModel & typeof DiffDoc;

src/diff.js

@@ -1,5 +1,5 @@
 // @flow
-/* eslint-disable no-param-reassign */
+/* eslint-disable no-param-reassign, no-plusplus */
 
 import {
   realTypeOf,
@@ -204,7 +204,7 @@ export const revertChanges = (target: any, changes: Array<RawChangeT>): any => {
         delete it[change.p[i]];
         break;
       default:
-        '';
+        it[change.p[i]] = {};
     }
   });
   return copyTarget;

src/utils.js

@@ -143,13 +143,12 @@ export const revertArrayChange = (arr: Array<any>, index: number, change: any):
         delete element[change.p[j]];
         break;
       default:
-        '';
+        return [];
     }
   } else {
     // the array item is different...
     switch (change.k) {
       case 'A':
-        // $FlowFixMe
         revertArrayChange(arr[index], change.i, change.it);
         break;
       case 'D':
@@ -162,7 +161,7 @@ export const revertArrayChange = (arr: Array<any>, index: number, change: any):
         arr = arrayRemove(arr, index);
         break;
       default:
-        '';
+        arr = [];
     }
   }
   return arr;
@@ -171,6 +170,7 @@ export const revertArrayChange = (arr: Array<any>, index: number, change: any):
 export const deepClone = (obj: any): any => {
   if (realTypeOf(obj) === 'object') {
     const clone = { ...obj };
+    // eslint-disable-next-line no-restricted-syntax
     for (const k in clone) {
       if (clone.hasOwnProperty(k)) {
         clone[k] = deepClone(clone[k]);