Skip to content

Prevent processing nodes in cases where the node ID is not known #80

@Poikilos

Description

@Poikilos
  1. Adding aliases to nodeIdToAlias and aliasToNode ID can result in sending messages to invalid (nextInternallyAssignedNodeID) NodeIDs.
  2. createNewRemoteNode may be triggered before the node ID is known
  3. @balazsracz says that openmrn has a queue for messages where resolution is not yet complete
    • and the Java implementation has a hashmap with callbacks
  4. RemoteNodeProcessor and LocalNodeProcessor are message layer classes, so they should probably only be notified of messages from nodes with known nodeids
  • This would prevent feature code (programs using the classes) from trying to send messages to them with invalid (nextInternallyAssignedNodeID) NodeIDs.

I will work on this and test the change, but let me know if you have comments or can explain more about what is trying to be accomplished in case we can accomplish things a different way (such as 3 above).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions