-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
- Adding aliases to nodeIdToAlias and aliasToNode ID can result in sending messages to invalid (
nextInternallyAssignedNodeID) NodeIDs. - createNewRemoteNode may be triggered before the node ID is known
- @balazsracz says that openmrn has a queue for messages where resolution is not yet complete
- and the Java implementation has a hashmap with callbacks
- RemoteNodeProcessor and LocalNodeProcessor are message layer classes, so they should probably only be notified of messages from nodes with known nodeids
- This would prevent feature code (programs using the classes) from trying to send messages to them with invalid (
nextInternallyAssignedNodeID) NodeIDs.
I will work on this and test the change, but let me know if you have comments or can explain more about what is trying to be accomplished in case we can accomplish things a different way (such as 3 above).
Metadata
Metadata
Assignees
Labels
No labels