Skip to content

Should a 1-byte (actually 1-nibble) destination alias be kept? #76

@Poikilos

Description

@Poikilos

Current code:

                if (len(frame.data) > 0):
                    destAlias |= (frame.data[0] & 0x0F) << 8  # rm f bits
                    # TODO: Is this ok when len(frame.data) <= 1? Still << 8?
                if (len(frame.data) > 1):
                    destAlias |= (frame.data[1] & 0xFF)

Should we have a warning below that?

                else:
                    logger.warning("Missing last 2 nibbles of address in received data")

or discard the CanFrame?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions