Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

Commit 661d8fb

Browse files
authored
Merge pull request #221 from hubert-deriv/new_manage_apps_design
2 parents d5e031e + 7eed28c commit 661d8fb

File tree

18 files changed

+103
-127
lines changed

18 files changed

+103
-127
lines changed

src/components/CustomCheckbox/custom_checkbox.module.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,15 @@
22

33
.customCheckboxContainer {
44
display: flex;
5-
align-items: center;
65
justify-content: center;
76
position: relative;
87
min-width: rem(1.6);
98
padding-top: rem(0.8);
109
z-index: 0;
1110
margin-bottom: auto;
11+
@media screen and (min-width: 992px) {
12+
align-items: center;
13+
}
1214
label {
1315
cursor: pointer;
1416
margin-left: rem(1.5);

src/features/dashboard/components/AppForm/__tests__/app-form.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ describe('App Form', () => {
201201
const submitButton = screen.getByText('Register Application');
202202

203203
const authURLInput = screen.getByRole('textbox', {
204-
name: 'Authorization URL (optional)',
204+
name: 'Authorisation URL (optional)',
205205
});
206206

207207
await userEvent.type(authURLInput, 'http:invalidAUTHurl.com');
@@ -290,7 +290,7 @@ describe('App Form', () => {
290290
});
291291

292292
const appRedirectUrlInput = screen.getByRole<HTMLInputElement>('textbox', {
293-
name: 'Authorization URL (optional)',
293+
name: 'Authorisation URL (optional)',
294294
});
295295

296296
const appVerificationUrlInput = screen.getByRole<HTMLInputElement>('textbox', {

src/features/dashboard/components/AppForm/app-form.module.scss

Lines changed: 27 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,10 @@ fieldset .customTextInput:last-child {
9090
display: flex;
9191
flex-direction: column;
9292
margin-bottom: rem(2.5);
93-
.scopesWrapper {
94-
padding-left: rem(1.6);
93+
@media screen and (min-width: 992px) {
94+
.scopesWrapper {
95+
margin-left: rem(1.6);
96+
}
9597
}
9698
}
9799
.disableTokenDropdown {
@@ -112,23 +114,31 @@ fieldset .customTextInput:last-child {
112114
margin-bottom: rem(2);
113115
}
114116
.formHeaderContainer {
117+
font-size: rem(1.4);
115118
display: flex;
116119
padding: rem(1) 0;
117120
gap: rem(1);
118121
margin-top: rem(1.5);
119122
flex-direction: column;
123+
120124
.subHeading {
121-
padding-left: rem(1);
125+
margin-left: rem(1);
122126
}
123127
.formsubHeading {
124-
padding: rem(1.6);
128+
margin-left: rem(1.6);
125129
display: inline-block;
126130
}
127131
.wrapperHeading {
128-
padding-left: rem(1.6);
132+
margin-left: rem(1.6);
129133
}
130-
.markup {
131-
margin-bottom: rem(1);
134+
}
135+
.markup {
136+
margin-bottom: rem(1);
137+
span {
138+
font-size: rem(1.2);
139+
@media screen and (min-width: 992px) {
140+
font-size: rem(1.4);
141+
}
132142
}
133143
}
134144
}
@@ -165,20 +175,27 @@ fieldset .customTextInput:last-child {
165175
.customCheckboxWrapper {
166176
display: flex;
167177
gap: rem(1);
178+
font-size: rem(1.2);
179+
@media screen and (min-width: 992px) {
180+
font-size: rem(1.4);
181+
}
168182

169183
label {
170184
cursor: pointer;
171185
}
172186
}
173187

174188
.termsOfConditionRegister {
175-
margin-left: rem(4);
176-
margin-top: rem(6);
189+
font-size: rem(1);
190+
text-align: center;
191+
@media screen and (min-width: 992px) {
192+
font-size: rem(1.4);
193+
}
177194
}
178195

179196
.buttons {
180197
display: flex;
181-
gap: rem(1);
198+
gap: rem(2.4);
182199
}
183200

184201
.errorAppname {

src/features/dashboard/components/AppForm/index.tsx

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,9 @@ const AppForm = ({
199199
</Text>
200200
<br />
201201
<Text as='span' type='paragraph-1' className={styles.formsubHeading}>
202-
<b>NOTE: Markup is only available for real accounts</b>
202+
<p>
203+
<b>Note: Markup is only available for real accounts.</b>
204+
</p>
203205
</Text>
204206
</div>
205207
</div>
@@ -248,14 +250,14 @@ const AppForm = ({
248250
type='text'
249251
placeholder=' '
250252
/>
251-
<label htmlFor='app_redirect_uri'>Authorization URL (optional)</label>
253+
<label htmlFor='app_redirect_uri'>Authorisation URL (optional)</label>
252254
</div>
253255
<Text
254256
as='p'
255257
type='paragraph-2'
256258
className={`${styles.helperText} ${styles.formsubHeading}`}
257259
>
258-
*Please note that this URL will be used as the OAuth redirect URL for the OAuth
260+
Please note that this URL will be used as the OAuth redirect URL for the OAuth
259261
authorization.
260262
</Text>
261263
{errors && errors?.redirect_uri && (
@@ -275,6 +277,11 @@ const AppForm = ({
275277
placeholder=' '
276278
/>
277279
<label htmlFor='app_verification_uri'>Verification URL (optional)</label>
280+
<Text
281+
as='p'
282+
type='paragraph-2'
283+
className={`${styles.helperText} ${styles.formsubHeading}`}
284+
></Text>
278285
</div>
279286
{errors && errors.verification_uri && (
280287
<span className='error-message'>{errors.verification_uri.message}</span>

src/features/dashboard/components/AppsTable/cells.module.scss

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@
33
@mixin actionIcon {
44
background-repeat: no-repeat;
55
background-position: center;
6-
background-size: rem(2);
6+
background-size: rem(1.8);
77
cursor: pointer;
8-
padding: rem(2) rem(2);
8+
padding: rem(1.8) rem(1.8);
99
border-radius: 100%;
10-
background-color: var(--colors-greyLight200);
11-
border: 2px solid var(--colors-greyLight400);
1210
}
1311

1412
.deleteApp {
@@ -23,8 +21,8 @@
2321

2422
.appActions {
2523
display: flex;
26-
gap: rem(2);
2724
margin: rem(3);
25+
justify-content: center;
2826
}
2927

3028
.tooltip {

src/features/dashboard/components/Dialogs/UpdateAppDialog/update-app-dialog.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
width: 80vw;
77

88
.update_app_content {
9-
margin: rem(2);
9+
margin: rem(1);
1010
}
1111
}

src/features/dashboard/components/RestrictionsAppname/RestrictionsAppname.module.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
@use 'src/styles/utility' as *;
22

33
.restrictions {
4+
display:flex;
5+
flex-direction: column;
6+
gap: rem(0.8);
47
font-size: rem(1.2);
58
font-weight: 400;
69
line-height: rem(1.8);

src/features/dashboard/components/RestrictionsAppname/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ import styles from './RestrictionsAppname.module.scss';
33

44
const RestrictionsAppname = () => {
55
return (
6-
<ol className={styles.restrictions}>
6+
<ul className={styles.restrictions}>
77
<li>Only alphanumeric characters with spaces and underscores are allowed.</li>
88
<li>The name can contain up to 48 characters.</li>
99
<li>Duplicate token names aren’t allowed.</li>
1010
<li>The name cannot contain “Binary”, “Deriv”, or similar words.</li>
11-
</ol>
11+
</ul>
1212
);
1313
};
1414

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
@use 'src/styles/utility' as *;
22

33
.scope {
4-
border: 1.6px solid var(--ifm-color-emphasis-400);
5-
border-radius: 4px;
6-
padding: rem(0.24) rem(0.24);
7-
font-size: rem(1.1);
4+
display: inline-block;
5+
border: rem(0.1) solid var(--ifm-color-emphasis-400);
6+
border-radius: 100vw; // pill shaped
7+
padding: rem(0.2) rem(0.8);
8+
font-size: rem(1.2);
9+
margin: rem(0.5);
10+
color: var(--ifm-color-emphasis-700);
811
}
912

1013
.adminScope {
11-
border: 1.6px solid var(--ifm-color-primary);
12-
color: var(--ifm-color-primary);
14+
border: rem(0.1) solid var(--admin-border);
15+
color: var(--admin-text);
1316
}

src/features/dashboard/components/Table/table.scss

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,30 @@
88
}
99

1010
thead {
11-
background-color: var(--ifm-color-emphasis-200);
12-
border: 3px solid var(--ifm-color-emphasis-200);
11+
background-color: var(--ifm-color-emphasis-100);
12+
border: 3px solid var(--ifm-color-emphasis-100);
1313
height: rem(5);
1414
}
1515

16+
th {
17+
min-width: rem(20);
18+
}
19+
1620
th,
1721
td {
22+
display: table-cell;
23+
border-left: none;
24+
border-right: none;
25+
border-bottom-color: var(--ifm-color-emphasis-200);
1826
text-align: left;
19-
padding: rem(1.6);
20-
min-width: rem(14.4);
21-
max-width: rem(14.4);
22-
overflow: visible;
23-
text-overflow: ellipsis;
24-
border: none;
27+
&:last-child {
28+
text-align: center;
29+
}
2530
}
2631

2732
td:nth-child(3) {
28-
display: flex;
29-
flex-wrap: wrap;
30-
gap: rem(0.64);
33+
max-width: rem(20);
34+
min-width: rem(15);
3135
}
3236

3337
td:last-child,
@@ -43,9 +47,8 @@
4347
}
4448

4549
tbody tr {
50+
display: table-row;
4651
border: none;
47-
&:nth-child(even) {
48-
background-color: var(--ifm-color-emphasis-100);
49-
}
52+
background-color: var(--ifm-color-emphasis-0);
5053
}
5154
}

0 commit comments

Comments
 (0)