Invalid TypoScript condition for CookieConsent in TYPO3 v13 ([{$page.theme.cookieconsent.enable} == 1])

[febuchner]

Bug Report

Prerequisites

• Can you reproduce the problem on TYPO3 v11.5 LTS
• Can you reproduce the problem on TYPO3 v12.4 LTS
• Can you reproduce the problem on TYPO3 v13.4
• Did you perform a cursory search
  to see if your bug or enhancement is already reported?

Description

The Bootstrap Package currently includes a TypoScript condition in Configuration/TypoScript/CookieConsent/setup.typoscript that is no longer valid in TYPO3 v12/v13:

[{$page.theme.cookieconsent.enable} == 1]
    page {
        includeJSFooterlibs {
            contrib_cookieconsent = EXT:bootstrap_package/Resources/Public/Contrib/cookieconsent/cookieconsent.min.js
            bootstrap_cookieconsent = EXT:bootstrap_package/Resources/Public/JavaScript/Dist/bootstrap.cookieconsent.min.js
        }
    }
[end]

Since TYPO3 v12, TypoScript conditions are parsed using the Symfony Expression Language. The legacy {$...} syntax is not supported anymore and causes a parse error.

Steps to Reproduce

1. Install TYPO3 v13.x with Bootstrap Package.
2. Enable the theme constants (default setup).
3. Load the frontend.

Expected behavior

The TypoScript condition should be parsed correctly.

Actual behavior

TYPO3 throws an error during TypoScript parsing:

TypoScript condition [{$page.theme.cookieconsent.enable} == 1] could not be parsed:
Unexpected character "$" around position 1 ...

Versions

TYPO3 v13.x (tested with 13.4)
bootstrap_package (latest release via Composer)

[netbrothers-tr]

I have tested the following with TYPO3 v13 and it worked for me. @febuchner, how does your solution look like? Currently I am patching inside the vendor folder to keep my log clean. @benjaminkott, first of all, thanks so much for providing this package! Does this look okay to you? Would you incorporate this solution or accept a PR?

-[{$page.theme.cookieconsent.enable} == 1]
+[traverse(site("configuration"), "settings/page/theme/cookieconsent/enable") == 1]
    page {
        includeJSFooterlibs {
            # COOKIE CONSENT
            contrib_cookieconsent = EXT:bootstrap_package/Resources/Public/Contrib/cookieconsent/cookieconsent.min.js
            bootstrap_cookieconsent = EXT:bootstrap_package/Resources/Public/JavaScript/Dist/bootstrap.cookieconsent.min.js
        }
    }
[end]

[patricksdd]

See this commit: a27086a