fix clippy errors and warnings

Author: beeequeue

src/node_version.rs

@@ -19,26 +19,26 @@ pub trait NodeVersion {
     fn version(&self) -> &Version;
 }
 
-impl PartialEq<Self> for dyn NodeVersion {
+impl PartialEq for dyn NodeVersion {
     fn eq(&self, other: &Self) -> bool {
         self.version().eq(other.version())
     }
 }
 
 impl Eq for dyn NodeVersion {}
 
-impl PartialOrd<Self> for dyn NodeVersion {
-    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        Some(self.version().cmp(other.version()))
-    }
-}
-
 impl Ord for dyn NodeVersion {
     fn cmp(&self, other: &Self) -> Ordering {
         self.version().cmp(other.version())
     }
 }
 
+impl PartialOrd for dyn NodeVersion {
+    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
+        Some(self.cmp(other))
+    }
+}
+
 pub fn parse_range(value: &str) -> Result<Range> {
     Range::parse(value).context(value.to_string())
 }
@@ -141,9 +141,9 @@ impl OnlineNodeVersion {
     }
 }
 
-impl ToString for OnlineNodeVersion {
-    fn to_string(&self) -> String {
-        self.version.to_string()
+impl std::fmt::Display for OnlineNodeVersion {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "{}", self.version)
     }
 }
 
@@ -268,9 +268,9 @@ impl InstalledNodeVersion {
     }
 }
 
-impl ToString for InstalledNodeVersion {
-    fn to_string(&self) -> String {
-        self.version.to_string()
+impl std::fmt::Display for InstalledNodeVersion {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "{}", self.version)
     }
 }
 

src/subcommand/install.rs

@@ -67,7 +67,7 @@ impl Action<InstallCommand> for InstallCommand {
         if config.force
             || (options.switch
                 && dialoguer::Confirm::new()
-                    .with_prompt(format!("Switch to {}?", version_to_install.to_string()))
+                    .with_prompt(format!("Switch to {}?", version_to_install))
                     .default(true)
                     .interact()?)
         {

src/subcommand/is_installed.rs

@@ -48,7 +48,7 @@ impl Action<IsInstalledCommand> for IsInstalledCommand {
             if !options.quiet {
                 println!(
                     "✅ A version matching {version_filter} is installed ({})!",
-                    installed_version.to_string()
+                    installed_version
                 );
             }
             return Ok(());

src/subcommand/list.rs

@@ -40,7 +40,7 @@ impl<'p> VersionStatus<'p> {
 
     fn to_version_string(&self) -> String {
         match self {
-            VersionStatus::Outdated(version) => format!("-> {}", version.to_string()),
+            VersionStatus::Outdated(version) => format!("-> {}", version),
             _ => "".to_string(),
         }
     }

src/subcommand/switch.rs

@@ -47,12 +47,12 @@ impl Action<SwitchCommand> for SwitchCommand {
         let version = version.unwrap();
 
         if !InstalledNodeVersion::is_installed(config, version.version()) {
-            anyhow::bail!("{} is not installed", version.to_string());
+            anyhow::bail!("{} is not installed", version);
         }
 
         let result = set_shims(config, version.version());
         if let Ok(()) = result {
-            println!("Switched to {}", version.to_string());
+            println!("Switched to {}", version);
         }
 
         result