Skip to content
This repository was archived by the owner on Jan 30, 2023. It is now read-only.

Commit babbdeb

Browse files
author
Albert Meltzer
committed
Cyclomatic complexity: skip the DO token
DO comes either with WHILE or FOR, and both are already counted.
1 parent 26ac3e8 commit babbdeb

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/main/scala/org/scalastyle/scalariform/CyclomaticComplexityChecker.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ package org.scalastyle.scalariform
1818

1919
import _root_.scalariform.lexer.Token
2020
import _root_.scalariform.lexer.Tokens.CASE
21-
import _root_.scalariform.lexer.Tokens.DO
2221
import _root_.scalariform.lexer.Tokens.FOR
2322
import _root_.scalariform.lexer.Tokens.IF
2423
import _root_.scalariform.lexer.Tokens.MATCH
@@ -39,7 +38,7 @@ class CyclomaticComplexityChecker extends CombinedChecker {
3938
val DefaultCountCases = true
4039
private lazy val maximum = getInt("maximum", DefaultMaximum)
4140
private lazy val countCases = getBoolean("countCases", DefaultCountCases)
42-
private val defaultTokens = Set(IF, WHILE, DO, FOR)
41+
private val defaultTokens = Set(IF, WHILE, FOR)
4342

4443
case class FunDefOrDclClazz(t: FunDefOrDcl, position: Option[Int], subs: List[FunDefOrDclClazz])
4544
extends Clazz[FunDefOrDcl]()

src/test/scala/org/scalastyle/scalariform/CyclomaticComplexityCheckerTest.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ class Foobar {
3939
5 match {
4040
case 4 =>
4141
case 5 =>
42+
case 6 =>
4243
case _ =>
4344
}
4445
} else {
@@ -49,7 +50,6 @@ class Foobar {
4950
3
5051
}
5152
}
52-
5353
def barbar(i: Int): Int = {
5454
if (i == 1) {
5555
5
@@ -65,6 +65,7 @@ class Foobar {
6565
while (f > 0) {}
6666
do {} while (f > 0)
6767
for (t <- List()) {}
68+
for (t <- List()) yield {}
6869
3
6970
}
7071
}

0 commit comments

Comments
 (0)