-
Notifications
You must be signed in to change notification settings - Fork 1.1k
configure.ac: use AC_PATH_TOOL for nm #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attention! This pull request may contain issues that could prevent it from being accepted. Please review the checklist below and take the recommended action. If you believe any of these are not applicable, just add a comment and let us know.
- The PR description does not match the commit message body. This can cause confusion for reviewers and future maintainers. GitHub doesn't automatically update the PR description when you update the commit message so if you've updated the commit with a force-push, please update the PR description to match the new commit message body.
Documentation:
|
Workflow PRCheck completed successfully |
jcolp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Asterisk project commits a generated configure script to make it easy for users. You will need to regenerate using bootstrap.sh and include the regenerated configure script in this change.
|
The PR check also needs to be fulfilled and branches specified. |
|
Running As to cherry-picking: |
|
Squash it all down to one commit, it's fine. |
|
Workflow PRCheck completed successfully |
|
Workflow PRCheck completed successfully |
nmmight, especially in cross-compilation scenarios, be available but prefixed with the target triple. So: useAC_PATH_TOOLrather thanAC_PATH_PROGto find it. (See https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html .)Found and proposed fix tested by cross-compiling Asterisk using Nixpkgs on x86_64 targeting aarch64. :)