Skip to content

Conversation

@nwf
Copy link

@nwf nwf commented Nov 25, 2025

nm might, especially in cross-compilation scenarios, be available but prefixed with the target triple. So: use AC_PATH_TOOL rather than AC_PATH_PROG to find it. (See https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html .)

Found and proposed fix tested by cross-compiling Asterisk using Nixpkgs on x86_64 targeting aarch64. :)

@sangoma-oss-cla
Copy link

sangoma-oss-cla bot commented Nov 25, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention! This pull request may contain issues that could prevent it from being accepted. Please review the checklist below and take the recommended action. If you believe any of these are not applicable, just add a comment and let us know.

  • The PR description does not match the commit message body. This can cause confusion for reviewers and future maintainers. GitHub doesn't automatically update the PR description when you update the commit message so if you've updated the commit with a force-push, please update the PR description to match the new commit message body.

Documentation:

@github-actions github-actions bot added the has-pr-checklist A PR Checklist is present on the PR label Nov 25, 2025
@github-actions
Copy link

Workflow PRCheck completed successfully

Copy link
Member

@jcolp jcolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Asterisk project commits a generated configure script to make it easy for users. You will need to regenerate using bootstrap.sh and include the regenerated configure script in this change.

@jcolp
Copy link
Member

jcolp commented Nov 27, 2025

The PR check also needs to be fulfilled and branches specified.

@nwf
Copy link
Author

nwf commented Nov 27, 2025

Running ./bootstrap.sh on 5d15a42 makes changes to ./configure. I've pulled those out to a commit prior to my change, and then ran ./bootstrap.sh again after AC_PATH_TOOL-ization of nm as a 3rd commit. Please feel free to squash appropriately, or tell me that I have done something wrong because the first of those should be empty.

As to cherry-picking:
cherry-pick-to: 23
cherry-pick-to: 22
cherry-pick-to: 20

@jcolp
Copy link
Member

jcolp commented Nov 27, 2025

Squash it all down to one commit, it's fine.

@github-actions
Copy link

Workflow PRCheck completed successfully

@github-actions
Copy link

Workflow PRCheck completed successfully

nwf pushed a commit to nwf/nixpkgs that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-pr-checklist A PR Checklist is present on the PR pr-submit-tests-passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants