add comment

mirkoCrobu · mirkoCrobu · commit 28d2ac4aa796 · 2025-12-22T11:42:25.000+01:00
diff --git a/internal/orchestrator/config/config.go b/internal/orchestrator/config/config.go
@@ -108,6 +108,9 @@ func NewFromEnv() (Configuration, error) {
 	}
 	maxVersionStr := os.Getenv("ARDUINO_APP_CLI__MAX_UPDATE_MAJOR_VERSION")
 
+	// If the value is 0 (or unset), the updater logic defaults to the currently installed major version.
+	//This ensures we don't accidentally upgrade to a new major version (breaking changes) unless explicitly allowed.
+
 	maxVersion, err := strconv.Atoi(maxVersionStr)
 	if err != nil || maxVersion <= 0 {
 		maxVersion = 0

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,9 @@ func NewFromEnv() (Configuration, error) {`
`108`	`108`	`}`
`109`	`109`	`maxVersionStr := os.Getenv("ARDUINO_APP_CLI__MAX_UPDATE_MAJOR_VERSION")`
`110`	`110`
	`111`	`+ // If the value is 0 (or unset), the updater logic defaults to the currently installed major version.`
	`112`	`+ //This ensures we don't accidentally upgrade to a new major version (breaking changes) unless explicitly allowed.`
	`113`	`+`
`111`	`114`	`maxVersion, err := strconv.Atoi(maxVersionStr)`
`112`	`115`	`if err != nil \|\| maxVersion <= 0 {`
`113`	`116`	`maxVersion = 0`