[WIP][SPARK-54372][SQL] ANSI mode should reject avg/sum on timestamp types #53373
+184
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In ANSI mode,
avg(timestamp)andsum(timestamp)now fail with a propertype error instead of silently casting to double.
Why are the changes needed?
Per SQL standards, AVG is only defined for numeric types. The current behavior
(inherited from Hive compatibility) silently casts timestamp to epoch seconds
as a double, which:
-979200.0for1969-12-21)Does this PR introduce any user-facing change?
Yes. In ANSI mode (
spark.sql.ansi.enabled=true), queries likeSELECT avg(timestamp_col) FROM tablewill now fail with: DATATYPE_MISMATCH.UNEXPECTED_INPUT_TYPE: The 1st parameter requires the NUMERIC or ANSI INTERVAL type, however timestamp_col has the type TIMESTAMP.Non-ANSI mode behavior is unchanged (backward compatible).
How was this patch tested?
AnsiTypeCoercionSuiteTypeCoercionSuiteWas this patch authored or co-authored using generative AI tooling?
No, except for PR description.