add checking existing speos features when create (#422)

same name feature was allowed when committing. 
* this is not same behaviour in scdm speos.
* as we reply on Find with name as searching method, it is better to
avoid having features with the same name

---------

Signed-off-by: plu <plu@ansys.com>
Co-authored-by: plu <plu@ansys.com>
Co-authored-by: Stefan Thöne <86405327+StefanThoene@users.noreply.github.com>

Author: 3 people

src/ansys/speos/script/project.py

@@ -95,6 +95,10 @@ def create_optical_property(self, name: str, description: str = "", metadata: Ma
         ansys.speos.script.opt_prop.OptProp
             OptProp feature.
         """
+        existing_features = self.find(name=name)
+        if len(existing_features) != 0:
+            msg = "Feature {}: {} has a conflict name with an existing feature.".format(opt_prop.OptProp, name)
+            raise ValueError(msg)
         feature = opt_prop.OptProp(project=self, name=name, description=description, metadata=metadata)
         self._features.append(feature)
         return feature
@@ -130,6 +134,10 @@ def create_source(
         Union[ansys.speos.script.source.Surface, ansys.speos.script.source.RayFile, ansys.speos.script.source.Luminaire]
             Source class instance.
         """
+        existing_features = self.find(name=name)
+        if len(existing_features) != 0:
+            msg = "Feature {}: {} has a conflict name with an existing feature.".format(feature_type, name)
+            raise ValueError(msg)
         feature = None
         if feature_type == source.Surface:
             feature = source.Surface(project=self, name=name, description=description, metadata=metadata)
@@ -171,6 +179,10 @@ def create_simulation(
         Union[ansys.speos.script.simulation.Direct, ansys.speos.script.simulation.Interactive, ansys.speos.script.simulation.Inverse]
             Simulation class instance
         """
+        existing_features = self.find(name=name)
+        if len(existing_features) != 0:
+            msg = "Feature {}: {} has a conflict name with an existing feature.".format(feature_type, name)
+            raise ValueError(msg)
         feature = None
         if feature_type == simulation.Direct:
             feature = simulation.Direct(project=self, name=name, description=description, metadata=metadata)
@@ -212,6 +224,10 @@ def create_sensor(
         Union[ansys.speos.script.sensor.Camera, ansys.speos.script.sensor.Radiance, ansys.speos.script.sensor.Irradiance]
             Sensor class instance.
         """
+        existing_features = self.find(name=name)
+        if len(existing_features) != 0:
+            msg = "Feature {}: {} has a conflict name with an existing feature.".format(feature_type, name)
+            raise ValueError(msg)
         feature = None
         if feature_type == sensor.Irradiance:
             feature = sensor.Irradiance(project=self, name=name, description=description, metadata=metadata)
@@ -538,8 +554,9 @@ def _fill_features(self):
             self._fill_bodies(body_guids=part_data.body_guids, feat_host=sp_feat)
 
         for mat_inst in scene_data.materials:
-            op_feature = self.create_optical_property(name=mat_inst.name)
-            op_feature._fill(mat_inst=mat_inst)
+            if len(self.find(name=mat_inst.name)) == 0:
+                op_feature = self.create_optical_property(name=mat_inst.name)
+                op_feature._fill(mat_inst=mat_inst)
 
         for src_inst in scene_data.sources:
             if src_inst.HasField("rayfile_properties"):

tests/workflow_tests/test_combine_speos.py

@@ -123,6 +123,7 @@ def test_insert_speos(speos: Speos):
     assert len(p.scene_link.get().sensors) == 1
     assert len(p.scene_link.get().sources) == 0
     assert len(p.scene_link.get().simulations) == 1
+    assert len(p.find(name=".*", name_regex=True, feature_type=script.opt_prop.OptProp)) == 7
 
     # Insert several speos files into the project - only geometries + materials are retrieved
     insert_speos(
@@ -143,6 +144,7 @@ def test_insert_speos(speos: Speos):
     assert len(p.scene_link.get().sensors) == 1
     assert len(p.scene_link.get().sources) == 0
     assert len(p.scene_link.get().simulations) == 1
+    assert len(p.find(name=".*", name_regex=True, feature_type=script.opt_prop.OptProp)) == 12
 
     # Check that the root part contains one part per speos to insert
     root_part = p.find(name="", feature_type=script.Part)[0]