-
Notifications
You must be signed in to change notification settings - Fork 84
AAP-60022 make drf-spectacular dep a range #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
adrisala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version enforcement was applied here. Note that 0.28.0 was used previously, so my guess is that there isn't any extra work needed.
https://github.com/ansible/django-ansible-base/pull/819/files#diff-a1fdfc6a989e34686b8b61b32379abee9be35a5c40277c51e74092684f9ec88cL53
|
DVCS PR Check Results: PR appears valid (JIRA key(s) found) |
|
Right, just to say this all out loud, the change @adrisala mentions bumped the version of drf-spectacular in My point here is that [tool.setuptools.dynamic]
dependencies = {file = ["requirements/requirements.in"]}
optional-dependencies.all = { file = [
"requirements/requirements_activitystream.in",
"requirements/requirements_authentication.in",
"requirements/requirements_api_documentation.in",
"requirements/requirements_rest_filters.in",
"requirements/requirements_channels.in",
"requirements/requirements_jwt_consumer.in",
"requirements/requirements_testing.txt",
"requirements/requirements_redis_client.in",
"requirements/requirements_oauth2_provider.in",
"requirements/requirements_resource_registry.in",
"requirements/requirements_feature_flags.in",
] }
optional-dependencies.activitystream = { file = [ "requirements/requirements_activitystream.in" ] }
optional-dependencies.authentication = { file = [ "requirements/requirements_authentication.in" ] } |
|
john-westcott-iv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with minor comment.
| @@ -1,2 +1,2 @@ | |||
| drf-spectacular==0.26.5 | |||
| referencing<0.37.0 # consistent with pin from jsonschema-path, via openapi-spec-validator | |||
| drf-spectacular<1.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always, can we add a comment in here regarding the pin change?



Description
DAB is a library, not an application. It needs to be packaged with version ranges as The Great Ones of software packaging intended.
Ping @tyraziel
Type of Change
Self-Review Checklist
Testing Instructions
Prerequisites
Steps to Test
Expected Results
Additional Context
Required Actions
Screenshots/Logs
Note
Relax drf-spectacular to a <1.0 range and bump resolved version to 0.29.0, retaining the referencing<0.37.0 pin.
drf-spectacularconstraint to<1.0inrequirements/requirements_api_documentation.in.drf-spectacularto0.29.0inrequirements/requirements_all.txt.referencing<0.37.0pin inrequirements/requirements_api_documentation.in.Written by Cursor Bugbot for commit 0d45302. This will update automatically on new commits. Configure here.