Skip to content

Conversation

@AlanCoding
Copy link
Member

@AlanCoding AlanCoding commented Dec 3, 2025

Description

DAB is a library, not an application. It needs to be packaged with version ranges as The Great Ones of software packaging intended.

Ping @tyraziel

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

Testing Instructions

Prerequisites

Steps to Test

Expected Results

Additional Context

Required Actions

  • Requires documentation updates
  • Requires downstream repository changes
  • Requires infrastructure/deployment changes
  • Requires coordination with other teams
  • Blocked by PR/MR: #XXX

Screenshots/Logs


Note

Relax drf-spectacular to a <1.0 range and bump resolved version to 0.29.0, retaining the referencing<0.37.0 pin.

  • Dependencies:
    • Relax drf-spectacular constraint to <1.0 in requirements/requirements_api_documentation.in.
    • Update resolved drf-spectacular to 0.29.0 in requirements/requirements_all.txt.
    • Keep referencing<0.37.0 pin in requirements/requirements_api_documentation.in.

Written by Cursor Bugbot for commit 0d45302. This will update automatically on new commits. Configure here.

@AlanCoding AlanCoding requested a review from huffmanca December 3, 2025 16:04
@AlanCoding AlanCoding marked this pull request as ready for review December 3, 2025 16:08
Copy link

@adrisala adrisala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version enforcement was applied here. Note that 0.28.0 was used previously, so my guess is that there isn't any extra work needed.
https://github.com/ansible/django-ansible-base/pull/819/files#diff-a1fdfc6a989e34686b8b61b32379abee9be35a5c40277c51e74092684f9ec88cL53

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

DVCS PR Check Results:

PR appears valid (JIRA key(s) found)

@AlanCoding
Copy link
Member Author

Right, just to say this all out loud, the change @adrisala mentions bumped the version of drf-spectacular in requirements/requirements_all.txt.

My point here is that requirements/requirements_all.txt doesn't actually matter, except internally for github checks here. The pyproject.toml references these files

[tool.setuptools.dynamic]
dependencies = {file = ["requirements/requirements.in"]}
optional-dependencies.all = { file = [
    "requirements/requirements_activitystream.in",
    "requirements/requirements_authentication.in",
    "requirements/requirements_api_documentation.in",
    "requirements/requirements_rest_filters.in",
    "requirements/requirements_channels.in",
    "requirements/requirements_jwt_consumer.in",
    "requirements/requirements_testing.txt",
    "requirements/requirements_redis_client.in",
    "requirements/requirements_oauth2_provider.in",
    "requirements/requirements_resource_registry.in",
    "requirements/requirements_feature_flags.in",
] }
optional-dependencies.activitystream = { file = [ "requirements/requirements_activitystream.in" ] }
optional-dependencies.authentication = { file = [ "requirements/requirements_authentication.in" ] }

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

Copy link
Member

@john-westcott-iv john-westcott-iv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor comment.

@@ -1,2 +1,2 @@
drf-spectacular==0.26.5
referencing<0.37.0 # consistent with pin from jsonschema-path, via openapi-spec-validator
drf-spectacular<1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, can we add a comment in here regarding the pin change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants