Skip to content

Conversation

@sourjyasen07
Copy link
Collaborator

updated the report specific landing page with some further details

updated the report specific landing page with some further details
sourjyasen07 and others added 7 commits January 6, 2022 15:15
updated the page with some further explanations
minor changes added
further edits to add module links
further edits to add module links
further edits to add module links
@ionicsolutions ionicsolutions changed the title update on the overview.md Revision of the Data Report documentation Jan 10, 2022
@kajanansangar
Copy link
Collaborator

kajanansangar commented Jan 19, 2022

@sourjyasen07 @ionicsolutions seems all the checks have failed for the above. Can we also add a sample report together with this merge?

@ionicsolutions
Copy link
Collaborator

@kajanansangar Thanks for the suggestion, we'll take this up!

It's fine for now that the test build fails: We're missing the correct links to the API docs and the test build is set to be super strict and fails if there's even one link that points to a missing file. With the API docs now merged, we can rebase this branch once we're happy with the content and fix the links to the API docs prior to merging.

@ionicsolutions
Copy link
Collaborator

@sourjyasen07 Could you please have a look if the "Generating data reports via the configuration file" section is complete and correct from your point of view?

Will you take care of filling in the "Generating data reports through individual modules" section and providing the example @kajanansangar sugested as well? I feel you're the most qualified to get this done quickly.

@sourjyasen07 @kajanansangar Do you have a suggestion where to document the configs.yaml file as well as the data and metric dictionaries? Providing examples is a good first step but users will want to know the specification and all options for these files. I don't think we need to solve it in this PR but it's an essential part for getting your own Anovos setup fully configured.

@ionicsolutions ionicsolutions marked this pull request as ready for review February 1, 2022 17:16
@ionicsolutions ionicsolutions requested review from kajanansangar and removed request for kajanansangar May 27, 2022 09:42
@ionicsolutions
Copy link
Collaborator

@sourjyasen07 Do you have any update on this PR?

@dattranm dattranm self-requested a review December 9, 2022 17:29
Copy link
Collaborator

@dattranm dattranm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The png images have pretty low quality and resolution, thus potentially the users may find it hard to see and interpret these images. Is there any way to increase the quality and resolution of these?

@bidyutparna
Copy link
Collaborator

Can you please point out which images are you referring to? @dattranm

Copy link
Collaborator

@dattranm dattranm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of images that need to be updated:

  • executive-report-1.png
  • executive-report-3.png
  • wiki-2.png
  • wiki-3.png
  • descriptive-statistics-2.png
  • descriptive-statistics-3.png
  • descriptive-statistics-4.png
  • descriptive-statistics-5.png
  • attribute-association-1.png

You can find them in anovos-docs/docs/assets/html-reports. Ideally, if possible, we should update all the old images that were added 13 months ago, but the list above is the most crucial for now.

_Anovos_ generates reports in two steps:

1. The data that will be included in the report is generated using the functions of the
[`data_analyzer`](../../docs/api/data-analyzer/_index.md)[`association_evaluator`](../../docs/api/data_analyzer/association-evaluator.md)[`data_drift_stability`](../../docs/api/drift_stability/index.md)[`quality_checker`](../../docs/api/data_analyzer/quality_checker.md) module.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in here, you can omit the docs too, so the link will become ../../api/data-analyzer/_index.md. This applies for all links with format ../../docs/* in here.

### Basic Report

In case you do not need an exhaustive report that contains all the detailed outputs of the
[`data_analyzer`](../../docs/api/data-analyzer/_index.md),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

### Full Report

The detailed and exhaustive full report contains a structured and well-formatted outputs of the
[`data_analyzer`](../../docs/api/data-analyzer/_index.md),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@bidyutparna
Copy link
Collaborator

@dattranm I have updated the above mentioned images along with a few others which had poor resolution. Also corrected the other typos. Please let me know if something else needs to be done.

@dattranm
Copy link
Collaborator

dattranm commented Dec 14, 2022

Hey @bidyutparna . Can you also address these comments as well? #18 (comment). When you remove the docs from there, the unit test in this PR should be working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants