TOB recommendations (#129)

* Added event when monetary policy is updated (#126)

* Disabling compiler optimizations (#128)

* Fixed `owner` variable shadowing issue (#127)

Author: aalavandhan

contracts/UFragments.sol

@@ -41,6 +41,7 @@ contract UFragments is ERC20Detailed, Ownable {
     event LogRebase(uint256 indexed epoch, uint256 totalSupply);
     event LogRebasePaused(bool paused);
     event LogTokenPaused(bool paused);
+    event LogMonetaryPolicyUpdated(address monetaryPolicy);
 
     // Used for authentication
     address public monetaryPolicy;
@@ -97,6 +98,7 @@ contract UFragments is ERC20Detailed, Ownable {
         onlyOwner
     {
         monetaryPolicy = monetaryPolicy_;
+        emit LogMonetaryPolicyUpdated(monetaryPolicy_);
     }
 
     /**
@@ -166,21 +168,21 @@ contract UFragments is ERC20Detailed, Ownable {
         return _totalSupply;
     }
 
-    function initialize(address owner)
+    function initialize(address owner_)
         public
         initializer
     {
         ERC20Detailed.initialize("UFragments", "AMPL", uint8(DECIMALS));
-        Ownable.initialize(owner);
+        Ownable.initialize(owner_);
 
         rebasePaused = false;
         tokenPaused = false;
 
         _totalSupply = INITIAL_FRAGMENTS_SUPPLY;
-        _gonBalances[owner] = TOTAL_GONS;
+        _gonBalances[owner_] = TOTAL_GONS;
         _gonsPerFragment = TOTAL_GONS.div(_totalSupply);
 
-        emit Transfer(address(0x0), owner, _totalSupply);
+        emit Transfer(address(0x0), owner_, _totalSupply);
     }
 
     /**
@@ -227,16 +229,16 @@ contract UFragments is ERC20Detailed, Ownable {
 
     /**
      * @dev Function to check the amount of tokens that an owner has allowed to a spender.
-     * @param owner The address which owns the funds.
+     * @param owner_ The address which owns the funds.
      * @param spender The address which will spend the funds.
      * @return The number of tokens still available for the spender.
      */
-    function allowance(address owner, address spender)
+    function allowance(address owner_, address spender)
         public
         view
         returns (uint256)
     {
-        return _allowedFragments[owner][spender];
+        return _allowedFragments[owner_][spender];
     }
 
     /**

contracts/UFragmentsPolicy.sol

@@ -187,11 +187,11 @@ contract UFragmentsPolicy is Ownable {
      *      It is called at the time of contract creation to invoke parent class initializers and
      *      initialize the contract's state variables.
      */
-    function initialize(address owner, UFragments uFrags_, uint256 baseCpi_)
+    function initialize(address owner_, UFragments uFrags_, uint256 baseCpi_)
         public
         initializer
     {
-        Ownable.initialize(owner);
+        Ownable.initialize(owner_);
 
         // deviationThreshold = 0.05e18 = 5e16
         deviationThreshold = 5 * 10 ** (DECIMALS-2);

test/unit/UFragments.js

@@ -88,6 +88,14 @@ contract('UFragments:setMonetaryPolicy', function (accounts) {
     await uFragments.setMonetaryPolicy(policy, { from: deployer });
     expect(await uFragments.monetaryPolicy.call()).to.eq(policy);
   });
+
+  it('should emit policy updated event', async function () {
+    const r = await uFragments.setMonetaryPolicy(policy, { from: deployer });
+    const log = r.logs[0];
+    expect(log).to.exist;
+    expect(log.event).to.eq('LogMonetaryPolicyUpdated');
+    expect(log.args.monetaryPolicy).to.eq(policy);
+  });
 });
 
 contract('UFragments:setMonetaryPolicy:accessControl', function (accounts) {

truffle.js

@@ -11,8 +11,7 @@ module.exports = {
       version: '0.4.24',
       settings: {
         optimizer: {
-          enabled: true,
-          runs: 1000000
+          enabled: false
         }
       }
     }