Skip to content

fix: trim whitespace in prtitles #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kouhaidev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: trim whitespace in prtitles #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,14 @@ async function run() {
}
}

const prTitle = pullRequest.title.trim()
// Pull requests that start with "[WIP] " are excluded from the check.
const isWip = wip && /^\[WIP\]\s/.test(pullRequest.title);
const isWip = wip && /^\[WIP\]\s/.test(prTitle);

let validationError;
if (!isWip) {
try {
await validatePrTitle(pullRequest.title, {
await validatePrTitle(prTitle, {
types,
scopes,
requireScope,
Expand Down Expand Up @@ -126,9 +127,9 @@ async function run() {
if (validateSingleCommitMatchesPrTitle) {
const commitTitle =
nonMergeCommits[0].commit.message.split('\n')[0];
if (commitTitle !== pullRequest.title) {
if (commitTitle !== prTitle) {
throw new Error(
`The pull request has only one (non-merge) commit and in this case Github will use it as the default commit message when merging. The pull request title doesn't match the commit though ("${pullRequest.title}" vs. "${commitTitle}"). Please update the pull request title accordingly to avoid surprises.`
`The pull request has only one (non-merge) commit and in this case Github will use it as the default commit message when merging. The pull request title doesn't match the commit though ("${prTitle}" vs. "${commitTitle}"). Please update the pull request title accordingly to avoid surprises.`
);
}
}
Expand Down
Loading