Skip to content

Commit 1e5e4af

Browse files
Gijsadrienbaron
authored andcommitted
Quickfixes for deprecated API usage, and removal of unused parameters
1 parent 01693b8 commit 1e5e4af

File tree

4 files changed

+27
-32
lines changed

4 files changed

+27
-32
lines changed

src/main/java/com/axellience/vuegwtplugin/VueGWTBundle.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@
33
import java.lang.ref.Reference;
44
import java.lang.ref.SoftReference;
55
import java.util.ResourceBundle;
6-
76
import org.jetbrains.annotations.NonNls;
87
import org.jetbrains.annotations.NotNull;
98
import org.jetbrains.annotations.PropertyKey;
10-
11-
import com.intellij.CommonBundle;
9+
import com.intellij.AbstractBundle;
1210

1311
public class VueGWTBundle
1412
{
@@ -24,7 +22,7 @@ private VueGWTBundle()
2422
public static String message(@NotNull @PropertyKey(resourceBundle = BUNDLE) String key,
2523
@NotNull Object... params)
2624
{
27-
return CommonBundle.message(getBundle(), key, params);
25+
return AbstractBundle.message(getBundle(), key, params);
2826
}
2927

3028
private static ResourceBundle getBundle()

src/main/java/com/axellience/vuegwtplugin/VueGWTFileWatcher.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
package com.axellience.vuegwtplugin;
22

3+
import org.jetbrains.annotations.NotNull;
4+
import org.jetbrains.annotations.Nullable;
35
import com.intellij.openapi.application.ApplicationManager;
46
import com.intellij.openapi.compiler.CompilerManager;
57
import com.intellij.openapi.diagnostic.Logger;
68
import com.intellij.openapi.editor.Document;
7-
import com.intellij.openapi.fileEditor.FileDocumentManagerAdapter;
9+
import com.intellij.openapi.fileEditor.FileDocumentManagerListener;
810
import com.intellij.openapi.module.Module;
911
import com.intellij.openapi.project.Project;
1012
import com.intellij.openapi.roots.ProjectFileIndex;
1113
import com.intellij.openapi.roots.ProjectRootManager;
1214
import com.intellij.openapi.vfs.VirtualFile;
1315
import com.intellij.psi.PsiDocumentManager;
1416
import com.intellij.psi.PsiFile;
15-
import org.jetbrains.annotations.NotNull;
16-
import org.jetbrains.annotations.Nullable;
1717

18-
public class VueGWTFileWatcher extends FileDocumentManagerAdapter {
18+
public class VueGWTFileWatcher implements FileDocumentManagerListener {
1919

2020
private static final Logger LOGGER = Logger.getInstance(VueGWTFileWatcher.class);
2121
private final Project project;
@@ -85,10 +85,6 @@ private VirtualFile getSibling(VirtualFile file, String siblingName) {
8585
return null;
8686
}
8787

88-
VirtualFile siblingFile = parent.findChild(siblingName);
89-
if (siblingFile == null) {
90-
return null;
91-
}
92-
return siblingFile;
88+
return parent.findChild(siblingName);
9389
}
9490
}

src/main/java/com/axellience/vuegwtplugin/annotators/JavaComponentAnnotator.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.axellience.vuegwtplugin.intentions.CreateTemplateIntention;
77
import com.intellij.lang.annotation.AnnotationHolder;
88
import com.intellij.lang.annotation.Annotator;
9+
import com.intellij.lang.annotation.HighlightSeverity;
910
import com.intellij.psi.PsiAnnotation;
1011
import com.intellij.psi.PsiAnnotationParameterList;
1112
import com.intellij.psi.PsiElement;
@@ -33,15 +34,15 @@ private void annotatePsiAnnotation(PsiAnnotation psiAnnotation,
3334
}
3435

3536
PsiFile javaFile = psiAnnotation.getContainingFile();
36-
if (!findHtmlTemplate(javaFile).isPresent()) {
37-
addCreateTemplateIntention(psiAnnotation, annotationHolder);
37+
if (findHtmlTemplate(javaFile).isEmpty()) {
38+
addCreateTemplateIntention(annotationHolder);
3839
}
3940
}
4041

41-
private void addCreateTemplateIntention(PsiElement psiElement,
42-
AnnotationHolder annotationHolder) {
43-
annotationHolder.createErrorAnnotation(psiElement, "Unresolved HTML Template")
44-
.registerFix(new CreateTemplateIntention());
42+
private void addCreateTemplateIntention(AnnotationHolder annotationHolder) {
43+
annotationHolder.newAnnotation(HighlightSeverity.ERROR, "Unresolved HTML Template")
44+
.withFix(new CreateTemplateIntention())
45+
.create();
4546
}
4647

4748
private boolean shouldHaveTemplate(PsiAnnotation psiAnnotation) {

src/main/java/com/axellience/vuegwtplugin/intentions/CreateTemplateIntention.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
package com.axellience.vuegwtplugin.intentions;
22

3+
import org.jetbrains.annotations.Nls;
4+
import org.jetbrains.annotations.Nls.Capitalization;
5+
import org.jetbrains.annotations.NotNull;
36
import com.axellience.vuegwtplugin.language.htmltemplate.HtmlTemplateFileType;
47
import com.axellience.vuegwtplugin.util.VueGWTPluginUtil;
58
import com.intellij.codeInsight.intention.impl.BaseIntentionAction;
@@ -11,9 +14,6 @@
1114
import com.intellij.psi.PsiFile;
1215
import com.intellij.psi.PsiFileFactory;
1316
import com.intellij.util.IncorrectOperationException;
14-
import org.jetbrains.annotations.Nls;
15-
import org.jetbrains.annotations.Nls.Capitalization;
16-
import org.jetbrains.annotations.NotNull;
1717

1818
public class CreateTemplateIntention extends BaseIntentionAction {
1919

@@ -38,21 +38,21 @@ public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile psiF
3838
@Override
3939
public void invoke(@NotNull Project project, Editor editor, PsiFile psiFile)
4040
throws IncorrectOperationException {
41-
ApplicationManager.getApplication().invokeLater(() -> createTemplate(project, editor, psiFile));
41+
ApplicationManager.getApplication().invokeLater(() -> createTemplate(project, psiFile));
4242
}
4343

44-
private void createTemplate(Project project, Editor editor, PsiFile javaFile) {
44+
private void createTemplate(Project project, PsiFile javaFile) {
4545
String templateName = VueGWTPluginUtil.getTemplateNameFrom(javaFile);
4646
PsiFile htmlFile = PsiFileFactory.getInstance(project).
4747
createFileFromText(templateName, HtmlTemplateFileType.INSTANCE, "<div></div>");
4848

49-
new WriteCommandAction.Simple(project, "Create HTML VueGwt Template '" + templateName + "'",
50-
htmlFile) {
51-
@Override
52-
protected void run() {
53-
PsiDirectory directory = javaFile.getContainingDirectory();
54-
directory.add(htmlFile);
55-
}
56-
}.execute();
49+
WriteCommandAction.runWriteCommandAction(project,
50+
"Create HTML VueGwt Template '" + templateName + "'",
51+
null,
52+
() -> {
53+
PsiDirectory directory = javaFile.getContainingDirectory();
54+
directory.add(htmlFile);
55+
},
56+
htmlFile);
5757
}
5858
}

0 commit comments

Comments
 (0)