Clean up random draw

Ilya Mandel · Ilya Mandel · commit e41220675e9c · 2025-06-26T13:39:53.000+10:00
diff --git a/src/BaseStar.cpp b/src/BaseStar.cpp
@@ -3909,7 +3909,7 @@ double BaseStar::DrawSNKickMagnitude(const double p_Sigma,
             if (thisSNevent == SN_EVENT::CCSN || (thisSNevent == SN_EVENT::PPISN && OPTIONS->NatalKickForPPISN())) {
                 // maximum kick of DISBERG_MANDEL_MAX_KICK = 1000 km/s, following Disberg & Mandel (2025)
                 // normalise the draw so that the kick is uniformly drawn from the inverse CDF below this maximum
-                double cdfMax = gsl_cdf_lognormal(DISBERG_MANDEL_MAX_KICK, DISBERG_MANDEL_MU, DISBERG_MANDEL_SIGMA);
+                double cdfMax = gsl_cdf_lognormal_P(DISBERG_MANDEL_MAX_KICK, DISBERG_MANDEL_MU, DISBERG_MANDEL_SIGMA);
                 kickMagnitude = gsl_cdf_lognormal_Pinv(p_Rand*cdfMax, DISBERG_MANDEL_MU, DISBERG_MANDEL_SIGMA);
             }
             else

Original file line number	Diff line number	Diff line change
`@@ -3909,7 +3909,7 @@ double BaseStar::DrawSNKickMagnitude(const double p_Sigma,`
`3909`	`3909`	`if (thisSNevent == SN_EVENT::CCSN \|\| (thisSNevent == SN_EVENT::PPISN && OPTIONS->NatalKickForPPISN())) {`
`3910`	`3910`	`// maximum kick of DISBERG_MANDEL_MAX_KICK = 1000 km/s, following Disberg & Mandel (2025)`
`3911`	`3911`	`// normalise the draw so that the kick is uniformly drawn from the inverse CDF below this maximum`
`3912`		`- double cdfMax = gsl_cdf_lognormal(DISBERG_MANDEL_MAX_KICK, DISBERG_MANDEL_MU, DISBERG_MANDEL_SIGMA);`
	`3912`	`+ double cdfMax = gsl_cdf_lognormal_P(DISBERG_MANDEL_MAX_KICK, DISBERG_MANDEL_MU, DISBERG_MANDEL_SIGMA);`
`3913`	`3913`	`kickMagnitude = gsl_cdf_lognormal_Pinv(p_Rand*cdfMax, DISBERG_MANDEL_MU, DISBERG_MANDEL_SIGMA);`
`3914`	`3914`	`}`
`3915`	`3915`	`else`