Skip to content

Commit a18921f

Browse files
committed
Added extra unit test cases
1 parent f8e964d commit a18921f

File tree

11 files changed

+73
-6
lines changed

11 files changed

+73
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,7 @@
22

33
### 0.0.1
44
- Initial version of python_osw_validation package.
5+
6+
### 0.0.2
7+
- Updated package Unit test cases.
8+
- Updated README file

README.md

Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,19 @@ This package validates the OSW geojson file. Package requires a OSW zip file pat
1818

1919
## Starting a new project with template
2020

21-
- Add `python-lib-osw-validation` package as dependency in your `requirements.txt`
22-
- or `pip install python-lib-osw-validation`
21+
- Add `python-osw-validation` package as dependency in your `requirements.txt`
22+
- or `pip install python-osw-validation`
2323
- Start using the packages in your code.
2424

2525
## Initialize and Configuration
2626

2727
```python
28-
from python_lib_osw_validation import OSWValidation
28+
from python_osw_validation import OSWValidation
2929

3030
validator = OSWValidation(zipfile_path='<Zip file path>')
3131
result = validator.validate()
3232
print(result.is_valid)
33-
print(result.error)
33+
print(result.errors)
3434

3535
```
3636

@@ -64,15 +64,35 @@ test_invalid_empty_directory (test_extracted_data_validator.TestExtractedDataVal
6464
test_invalid_missing_files_directory (test_extracted_data_validator.TestExtractedDataValidator) ... ok
6565
test_invalid_missing_required_files_directory (test_extracted_data_validator.TestExtractedDataValidator) ... ok
6666
test_valid_directory_structure (test_extracted_data_validator.TestExtractedDataValidator) ... ok
67+
test_wrong_datatypes_zipfile (test_osw_validation.TestOSWValidation) ... ["Validation error: {'type': 'Feature', 'geometry': {'type': 'Point', 'coordinates': [-122.1361808, 47.6403535]}, 'properties': {'amenity': 'amenity', '_id': '4293205373'}} is not valid under any of the given schemas"]
68+
ok
69+
test_extract_invalid_zip (test_zipfile_handler.TestZipFileHandler) ... ok
70+
test_extract_valid_zip (test_zipfile_handler.TestZipFileHandler) ... ok
71+
test_remove_extracted_files (test_zipfile_handler.TestZipFileHandler) ... ok
72+
73+
----------------------------------------------------------------------
74+
Ran 8 tests in 0.847s
75+
76+
OK
77+
(venv) anujkumar@Anujs-MacBook-Pro TDEI-python-lib-osw-validation % coverage run --source=src/python_osw_validation -m unittest discover -v tests/unit_tests
78+
test_invalid_empty_directory (test_extracted_data_validator.TestExtractedDataValidator) ... ok
79+
test_invalid_missing_files_directory (test_extracted_data_validator.TestExtractedDataValidator) ... ok
80+
test_invalid_missing_required_files_directory (test_extracted_data_validator.TestExtractedDataValidator) ... ok
81+
test_valid_directory_structure (test_extracted_data_validator.TestExtractedDataValidator) ... ok
6782
test_edges_invalid_zipfile (test_osw_validation.TestOSWValidation) ... ok
6883
test_edges_invalid_zipfile_with_invalid_schema (test_osw_validation.TestOSWValidation) ... ok
6984
test_edges_invalid_zipfile_with_schema (test_osw_validation.TestOSWValidation) ... ok
85+
test_extra_field_zipfile (test_osw_validation.TestOSWValidation) ... ok
86+
test_id_missing_zipfile (test_osw_validation.TestOSWValidation) ... ok
87+
test_invalid_geometry_zipfile (test_osw_validation.TestOSWValidation) ... ok
7088
test_invalid_zipfile (test_osw_validation.TestOSWValidation) ... ok
7189
test_invalid_zipfile_with_invalid_schema (test_osw_validation.TestOSWValidation) ... ok
7290
test_invalid_zipfile_with_schema (test_osw_validation.TestOSWValidation) ... ok
7391
test_missing_files_inside_zipfile (test_osw_validation.TestOSWValidation) ... ok
7492
test_missing_files_inside_zipfile_with_invalid_schema (test_osw_validation.TestOSWValidation) ... ok
7593
test_missing_files_inside_zipfile_with_schema (test_osw_validation.TestOSWValidation) ... ok
94+
test_missing_identifier_zipfile (test_osw_validation.TestOSWValidation) ... ok
95+
test_no_entity_zipfile (test_osw_validation.TestOSWValidation) ... ok
7696
test_nodes_invalid_zipfile (test_osw_validation.TestOSWValidation) ... ok
7797
test_nodes_invalid_zipfile_with_invalid_schema (test_osw_validation.TestOSWValidation) ... ok
7898
test_nodes_invalid_zipfile_with_schema (test_osw_validation.TestOSWValidation) ... ok
@@ -82,12 +102,13 @@ test_points_invalid_zipfile_with_schema (test_osw_validation.TestOSWValidation)
82102
test_valid_zipfile (test_osw_validation.TestOSWValidation) ... ok
83103
test_valid_zipfile_with_invalid_schema (test_osw_validation.TestOSWValidation) ... ok
84104
test_valid_zipfile_with_schema (test_osw_validation.TestOSWValidation) ... ok
105+
test_wrong_datatypes_zipfile (test_osw_validation.TestOSWValidation) ... ok
85106
test_extract_invalid_zip (test_zipfile_handler.TestZipFileHandler) ... ok
86107
test_extract_valid_zip (test_zipfile_handler.TestZipFileHandler) ... ok
87108
test_remove_extracted_files (test_zipfile_handler.TestZipFileHandler) ... ok
88109

89110
----------------------------------------------------------------------
90-
Ran 25 tests in 85.914s
111+
Ran 31 tests in 193.358s
91112

92113
OK
93114

freeze_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
build_date = date.today().strftime('%Y-%m-%d')
1313

14-
version = '0.0.1'
14+
version = '0.0.2'
1515

1616
with open(version_file_path, 'w+') as version_file:
1717
version_file.write("version = '{}'\n".format(version))

tests/assets/_id_missing.zip

194 KB
Binary file not shown.

tests/assets/extra_field.zip

194 KB
Binary file not shown.

tests/assets/invalid_geometry.zip

194 KB
Binary file not shown.
194 KB
Binary file not shown.

tests/assets/multiple_entries.zip

194 KB
Binary file not shown.

tests/assets/no_entity.zip

194 KB
Binary file not shown.

tests/assets/wrong_datatype.zip

194 KB
Binary file not shown.

0 commit comments

Comments
 (0)