Commit 0977c0b
committed
Fixed Task-1634
- Add geometry-aware schema selection (Point/LineString/Polygon) with sensible defaults
- Stream jsonschema_rs errors; keep legacy `errors` capped by `max_errors`
- Introduce `ValidationResult.issues` (one best error per feature) and set `errors=None` when empty
- Add friendly formatting:
- compact Enum messages
- summarize anyOf required keys (“must include one of: …”)
helpers:
- _feature_index_from_error: extract feature index from error.instance_path
- _err_kind: normalize/derive validator kind from jsonschema_rs error
- _pretty_message: produce concise, user-friendly text; handles Enum/AnyOf specially
- _rank_for: rank errors to choose a single best error per feature
- _get_colset: safe set extraction with diagnostics for missing columns
test: add comprehensive unit tests
- tests/test_helpers.py: covers _feature_index_from_error, _err_kind, _pretty_message, _rank_for, _get_colset
- tests/test_schema_selection.py: geometry-derived and filename fallback selection
- tests/test_validation_issues.py: streaming aggregation, best-error wins, `max_errors` cap behavior
- tests/test_integrity_checks.py: _id uniqueness; edges._u_id/_v_id and zones._w_id membership vs nodes._id
- tests/test_extensions.py: extension read failures, invalid geometries, _id fallback to index, non-serializable props
BREAKING CHANGE: ValidationResult now exposes `issues` and may return `errors=None` (not `[]`).
Downstream consumers must treat `errors` as Optional and prefer `issues` for per-feature UX.1 parent f986c1f commit 0977c0b
File tree
9 files changed
+3836
-113
lines changed- src/python_osw_validation
- schema
- tests/unit_tests
9 files changed
+3836
-113
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
3 | 29 | | |
4 | 30 | | |
5 | 31 | | |
| |||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
0 commit comments