fix: dynamic unique camera name

Author: wanasart

server/src/services/cameras/cameras.service.ts

@@ -40,9 +40,9 @@ export async function getCameraById(camera_id: number) {
   const { rows } = await pool.query(`
     SELECT * FROM v_cameras_overview
     WHERE camera_id = $1;
-  `,[
-      camera_id
-    ]
+  `, [
+    camera_id
+  ]
   );
 
   return rows;
@@ -82,17 +82,46 @@ export async function summaryCameras() {
  * @author Wanasart
  * @lastModified 2025-10-25
  */
-export async function insertCamera (
-  camera_name: string, 
-  camera_type: string, 
-  camera_status: boolean, 
-  source_type: string, 
-  source_value: string, 
-  location_id: number, 
-  description: string, 
+export async function insertCamera(
+  camera_name: string,
+  camera_type: string,
+  camera_status: boolean,
+  source_type: string,
+  source_value: string,
+  location_id: number,
+  description: string,
   creator_id: number
-){
-  const { rows } = await pool.query(`
+) {
+  
+  // 1) normalize + validate ชื่อ
+  const name = camera_name.trim();
+  if (!name) {
+    const err: any = new Error("CAMERA_NAME_REQUIRED");
+    err.code = "CAMERA_NAME_REQUIRED";
+    throw err;
+  }
+
+  // 2) เช็กชื่อซ้ำ (เฉพาะกล้องที่ยังใช้งานอยู่)
+  const dupCheck = await pool.query(
+    `
+    SELECT cam_id
+    FROM cameras
+    WHERE cam_is_use = TRUE
+      AND LOWER(cam_name) = LOWER($1)
+    LIMIT 1;
+    `,
+    [name]
+  );
+
+  if (dupCheck.rows.length > 0) {
+    const err: any = new Error("DUPLICATE_CAMERA_NAME");
+    err.code = "DUPLICATE_CAMERA_NAME";
+    throw err;
+  }
+
+  // 3) insert camera
+  const { rows } = await pool.query(
+    `
     INSERT INTO cameras(
       cam_name, 
       cam_type,
@@ -105,30 +134,42 @@ export async function insertCamera (
     )
     VALUES($1, $2, $3, $4, $5, $6, $7, $8)
     RETURNING *
-  `,[
-      camera_name, 
-      camera_type, 
-      camera_status, 
-      source_type, 
-      source_value, 
-      location_id, 
-      description, 
-      creator_id
-    ]);
-
-    const log = await pool.query(`
-      INSERT INTO camera_logs(
-        clg_usr_id,
-        clg_cam_id,
-        clg_action,
-        clg_created_at
-      )
-      VALUES($1, $2, $3, CURRENT_TIMESTAMP);
-    `,[
-        creator_id,
-        rows[0].cam_id,
-        'CREATE',
-      ]);
+    `,
+    [
+      name,
+      camera_type,
+      camera_status,
+      source_type,
+      source_value,
+      location_id,
+      description,
+      creator_id,
+    ]
+  );
+
+  if (!rows[0]) {
+    const err: any = new Error("CAMERA_INSERT_FAILED");
+    err.code = "CAMERA_INSERT_FAILED";
+    throw err;
+  }
+
+  // 4) log
+  await pool.query(
+    `
+    INSERT INTO camera_logs(
+      clg_usr_id,
+      clg_cam_id,
+      clg_action,
+      clg_created_at
+    )
+    VALUES($1, $2, $3, CURRENT_TIMESTAMP);
+    `,
+    [
+      creator_id,
+      rows[0].cam_id,
+      "CREATE",
+    ]
+  );
 
   return Mapping.mapCameraToSaveResponse(rows[0]);
 }
@@ -152,7 +193,7 @@ export async function insertCamera (
  * @author Wanasart
  * @lastModified 2025-10-25
  */
-export async function updateCamera (
+export async function updateCamera(
   camera_id: number,
   camera_name: string,
   camera_type: string,
@@ -164,6 +205,37 @@ export async function updateCamera (
   user_id: number
 ) {
 
+  // 1) normalize ชื่อนิดหน่อย
+  const name = camera_name.trim();
+
+  if (!name) {
+    const err: any = new Error("CAMERA_NAME_REQUIRED");
+    err.code = "CAMERA_NAME_REQUIRED";
+    throw err;
+  }
+
+  // 2) เช็กชื่อซ้ำเฉพาะกล้องที่ยังใช้งาน (cam_is_use = TRUE) และไม่ใช่ตัวเอง
+  const dupCheck = await pool.query(
+    `
+    SELECT cam_id
+    FROM cameras
+    WHERE cam_is_use = TRUE
+      AND LOWER(cam_name) = LOWER($1)
+      AND cam_id <> $2
+    LIMIT 1;
+    `,
+    [name, camera_id]
+  );
+
+  const count = dupCheck.rowCount ?? 0;
+
+  if (count > 0) {
+    const err: any = new Error("DUPLICATE_CAMERA_NAME");
+    err.code = "DUPLICATE_CAMERA_NAME";
+    throw err;
+  }
+
+  // 3) อัปเดตกล้อง (จะอัปเดตตัวที่ soft delete แล้วก็ได้หรือไม่ก็แล้วแต่กติกา)
   const { rows } = await pool.query(
     `
     UPDATE cameras
@@ -180,7 +252,7 @@ export async function updateCamera (
     RETURNING *;
     `,
     [
-      camera_name,
+      name,
       camera_type,
       camera_status,
       source_type,
@@ -191,19 +263,25 @@ export async function updateCamera (
     ]
   );
 
-  const log = await pool.query(`
+  if (rows.length === 0) {
+    const err: any = new Error("CAMERA_NOT_FOUND");
+    err.code = "CAMERA_NOT_FOUND";
+    throw err;
+  }
+
+  await pool.query(`
       INSERT INTO camera_logs(
         clg_usr_id,
         clg_cam_id,
         clg_action,
         clg_created_at
       )
       VALUES($1, $2, $3, CURRENT_TIMESTAMP);
-    `,[
-        user_id,
-        rows[0].cam_id,
-        'UPDATE',
-      ]);
+    `, [
+    user_id,
+    rows[0].cam_id,
+    'UPDATE',
+  ]);
 
   return Mapping.mapCameraToSaveResponse(rows[0]);
 }
@@ -245,11 +323,11 @@ export async function removeCamera(
         clg_created_at
       )
       VALUES($1, $2, $3, CURRENT_TIMESTAMP);
-    `,[
-        user_id,
-        rows[0].cam_id,
-        'DELETE',
-      ]);
+    `, [
+    user_id,
+    rows[0].cam_id,
+    'DELETE',
+  ]);
 
   return Mapping.mapCameraToSaveResponse(rows[0]);
 }