Fix LPC memmap, add device tests

Author: Steve-Tech

cros_ec_python/lpc.py

@@ -5,7 +5,7 @@
 
 
 def ec_init(address: Int32 = EC_LPC_ADDR_MEMMAP):
-    if portio.ioperm(EC_LPC_ADDR_MEMMAP, EC_MEMMAP_SIZE, True):
+    if portio.ioperm(address, EC_MEMMAP_SIZE, True):
         print("Permission denied. Try running as root.")
         exit(1)
 
@@ -17,6 +17,7 @@ def ec_readmem(offset: Int32, num_bytes: Int32, address: Int32 = EC_LPC_ADDR_MEM
     @param num_bytes: Number of bytes to read.
     @return: Bytes read from the EC.
     """
-    buf = None
-    print(portio.insb(address + offset, buf, num_bytes))
-    return buf
+    data = bytearray()
+    for i in range(num_bytes):
+        data.append(portio.inb(address + offset + i))
+    return bytes(data)

tests/devices.py

@@ -0,0 +1,42 @@
+import unittest
+from cros_ec_python import CrOS_EC, DeviceTypes, general
+from cros_ec_python.constants import MEMMAP
+
+ec: CrOS_EC | None = None
+
+
+class TestLinuxDev(unittest.TestCase):
+    def test1_init(self):
+        global ec
+        ec = CrOS_EC(DeviceTypes.LinuxDev)
+        self.assertIsNotNone(ec)
+
+    def test2_memmap(self):
+        resp = ec.memmap(MEMMAP.EC_MEMMAP_ID, 2)
+        self.assertEqual(resp, b'EC')
+
+    def test3_hello(self):
+        data = b'ECEC'
+        resp = ec.command(0, general.EC_CMD_HELLO, len(data), 4, data)
+        self.assertEqual(resp, (int.from_bytes(data, "little") + 0x01020304).to_bytes(4, "little"))
+
+
+class TestLPC(unittest.TestCase):
+    def test1_init(self):
+        global ec
+        ec = CrOS_EC(DeviceTypes.LPC, address=0xE00)
+        self.assertIsNotNone(ec)
+
+    def test2_memmap(self):
+        resp = ec.memmap(MEMMAP.EC_MEMMAP_ID, 2)
+        self.assertEqual(resp, b'EC')
+
+    @unittest.skip("Not implemented")
+    def test3_hello(self):
+        data = b'ECEC'
+        resp = ec.command(0, general.EC_CMD_HELLO, len(data), 4, data)
+        self.assertEqual(resp, (int.from_bytes(data, "little") + 0x01020304).to_bytes(4, "little"))
+
+
+if __name__ == '__main__':
+    unittest.main()