Fixed test failing on symfony 4

Author: caciobanu

src/DependencyInjection/DoctrineOrmBridgeExtension.php

@@ -9,6 +9,8 @@
 
 class DoctrineOrmBridgeExtension extends ConfigurableExtension
 {
+    private $alias;
+
     public function __construct($alias)
     {
         $this->alias = $alias;

src/DependencyInjection/EventBusExtension.php

@@ -10,6 +10,8 @@
 
 class EventBusExtension extends ConfigurableExtension
 {
+    private $alias;
+
     public function __construct($alias)
     {
         $this->alias = $alias;

tests/SymfonyBundle/DependencyInjection/Compiler/ConfigureMiddlewaresTest.php

@@ -5,6 +5,7 @@
 use SimpleBus\SymfonyBridge\DependencyInjection\Compiler\ConfigureMiddlewares;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
+use Symfony\Component\HttpKernel\Kernel;
 
 class ConfigureMiddlewaresTest extends \PHPUnit_Framework_TestCase
 {
@@ -35,41 +36,57 @@ protected function setUp()
      */
     public function it_configures_a_chain_of_buses_according_to_the_given_priorities()
     {
-        $this->createBusDefinition('middleware100', 100);
-        $this->createBusDefinition('middleware-100', -100);
-        $this->createBusDefinition('middleware200', 200);
+        $classes = [
+            'SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Auto\AuteEvent1' => 100,
+            'SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Auto\AuteEvent2' => -100,
+            'SimpleBus\SymfonyBridge\Tests\Functional\SmokeTest\Auto\AuteEvent3' => 200,
+        ];
+
+        foreach ($classes as $class => $priority) {
+            $this->createBusDefinition($class, $priority);
+        }
 
         $this->container->compile();
 
-        $this->commandBusContainsMiddlewares(array('middleware200', 'middleware100', 'middleware-100'));
+        $this->commandBusContainsMiddlewares($classes);
     }
 
-    private function createBusDefinition($id, $priority)
+    private function createBusDefinition($class, $priority)
     {
-        $definition = new Definition('stdClass');
+        $definition = new Definition($class);
         $definition->addTag($this->middlewareTag, array('priority' => $priority));
 
-        $this->container->setDefinition($id, $definition);
+        $this->container->setDefinition($class, $definition);
 
         return $definition;
     }
 
-    private function commandBusContainsMiddlewares($expectedMiddlewareIds)
+    private function commandBusContainsMiddlewares($expectedMiddlewareclasses)
     {
-        $actualMiddlewareIds = [];
+        $actualMiddlewareClasses = [];
 
         foreach ($this->mainBusDefinition->getMethodCalls() as $methodCall) {
             list($method, $arguments) = $methodCall;
             $this->assertSame('appendMiddleware', $method);
             $this->assertCount(1, $arguments);
             $referencedService = $arguments[0];
-            $this->assertInstanceOf(
-                'Symfony\Component\DependencyInjection\Reference',
-                $referencedService
-            );
-            $actualMiddlewareIds[] = (string) $referencedService;
+
+            if (Kernel::VERSION_ID >= 40000) {
+                $this->assertInstanceOf(
+                    'Symfony\Component\DependencyInjection\Definition',
+                    $referencedService
+                );
+            } else {
+                $this->assertInstanceOf(
+                    'Symfony\Component\DependencyInjection\Reference',
+                    $referencedService
+                );
+                $referencedService = $this->container->getDefition((string) $referencedService);
+            }
+
+            $actualMiddlewareClasses[$referencedService->getClass()] = $referencedService->getTag('middleware')[0]['priority'];
         }
 
-        $this->assertEquals($expectedMiddlewareIds, $actualMiddlewareIds);
+        $this->assertEquals($expectedMiddlewareclasses, $actualMiddlewareClasses);
     }
 }