Skip to content

Examples for alarm notifications do not reflect the specification #668

@ArjenR

Description

@ArjenR

See /mdbook/src/notifications.md

The specifications are for a path of notifications.mob.<a key> but the examples show "path": "notifications.mob"

I think this is also implemented not to spec in schemas/groups/notifications.json or there is an error in the regexp?

Line 46: "(^((?!^mob$|^fire$|^sinking$|^flooding$|^collision$|^grounding$|^listing$|^adrift$|^piracy$|^abandon$)[A-Za-z0-9-])+$)": {

Should the regex perhaps be more like ((mob|fire|sinking|flooding|collision|grounding|listing|adrift|piracy|abandon)\.[A-Za-z0-9]+$)

Therefore there are different implementations. Like in KIP.
KIP has this implemented like specified, but FreeboardSK like in the example below. So alarm raised by FreeboardSK cannot be acknowledged in KIP.

{
  "context": "vessels.urn:mrn:signalk:uuid:c0d79334-4e25-4245-8892-54e8ccc8021d",
  "updates": [
    {
      "source": {...},
      "timestamp": "2017-08-15T16:00:05.200Z",
      "values": [
        {
          "path": "notifications.mob",
          "value": {
            "message": "MOB",
            "state": "emergency",
            "method": ["visual", "sound"]
          }
        }
      ]
    }
  ]
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions