From a32a07a3ef9e01b553c308a373bd9eff0234d188 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Fri, 21 Oct 2022 06:20:56 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- pkg_manager/local_packagedir.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/pkg_manager/local_packagedir.py b/pkg_manager/local_packagedir.py index 2fce7bc..6522014 100644 --- a/pkg_manager/local_packagedir.py +++ b/pkg_manager/local_packagedir.py @@ -17,6 +17,25 @@ def put(self, package, path): os.makedirs(self.basedir) with tarfile.open(path) as f: - f.extractall( + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, os.path.join(self.basedir,package.name,package.version)) os.path.join(self.basedir, package.name, package.version) )