Do not create default partition for hash partioning

Author: Anexen

docs/source/table_partitioning.rst

@@ -42,6 +42,7 @@ Inherit your model from :class:`psqlextra.models.PostgresPartitionedModel` and d
 
 * Use :attr:`psqlextra.types.PostgresPartitioningMethod.RANGE` to ``PARTITION BY RANGE``
 * Use :attr:`psqlextra.types.PostgresPartitioningMethod.LIST` to ``PARTITION BY LIST``
+* Use :attr:`psqlextra.types.PostgresPartitioningMethod.HASH` to ``PARTITION BY HASH``
 
 .. code-block:: python
 

psqlextra/backend/migrations/patched_autodetector.py

@@ -8,7 +8,6 @@
     DeleteModel,
     RemoveField,
     RenameField,
-    RunSQL,
 )
 from django.db.migrations.autodetector import MigrationAutodetector
 from django.db.migrations.operations.base import Operation
@@ -19,6 +18,7 @@
     PostgresPartitionedModel,
     PostgresViewModel,
 )
+from psqlextra.types import PostgresPartitioningMethod
 
 from . import operations
 
@@ -140,11 +140,12 @@ def add_create_partitioned_model(
         partitioning_options = model._partitioning_meta.original_attrs
         _, args, kwargs = operation.deconstruct()
 
-        self.add(
-            operations.PostgresAddDefaultPartition(
-                model_name=model.__name__, name="default"
+        if partitioning_options["method"] != PostgresPartitioningMethod.HASH:
+            self.add(
+                operations.PostgresAddDefaultPartition(
+                    model_name=model.__name__, name="default"
+                )
             )
-        )
 
         self.add(
             operations.PostgresCreatePartitionedModel(

tests/test_make_migrations.py

@@ -57,11 +57,21 @@ def test_make_migration_create_partitioned_model(fake_app, model_config):
     migration = make_migration(model._meta.app_label)
     ops = migration.operations
 
-    # should have one operation to create the partitioned model
-    # and one more to add a default partition
-    assert len(ops) == 2
-    assert isinstance(ops[0], operations.PostgresCreatePartitionedModel)
-    assert isinstance(ops[1], operations.PostgresAddDefaultPartition)
+    if model_config["partitioning_options"]["method"] == PostgresPartitioningMethod.HASH:
+        # should have one operation to create the partitioned model
+        # and no default partition
+        assert len(ops) == 1
+        assert isinstance(ops[0], operations.PostgresCreatePartitionedModel)
+    else:
+        # should have one operation to create the partitioned model
+        # and one more to add a default partition
+        assert len(ops) == 2
+        assert isinstance(ops[0], operations.PostgresCreatePartitionedModel)
+        assert isinstance(ops[1], operations.PostgresAddDefaultPartition)
+
+        # make sure the default partition is named "default"
+        assert ops[1].model_name == model.__name__
+        assert ops[1].name == "default"
 
     # make sure the base is set correctly
     assert len(ops[0].bases) == 1
@@ -70,10 +80,6 @@ def test_make_migration_create_partitioned_model(fake_app, model_config):
     # make sure the partitioning options got copied correctly
     assert ops[0].partitioning_options == model_config["partitioning_options"]
 
-    # make sure the default partition is named "default"
-    assert ops[1].model_name == model.__name__
-    assert ops[1].name == "default"
-
 
 @postgres_patched_migrations()
 def test_make_migration_create_view_model(fake_app):