Merge pull request #102 from Scalr/fix/SCALRCORE-25897

SCALRCORE-25897: Remove ReadBySemanticVersion && make validString && …

Author: emocharnik

.gitignore

@@ -1,2 +1,3 @@
 .vscode/
 .idea/
+covprofile

module_version.go

@@ -16,8 +16,6 @@ type ModuleVersions interface {
 	List(ctx context.Context, options ModuleVersionListOptions) (*ModuleVersionList, error)
 	// Read a module version by its ID.
 	Read(ctx context.Context, moduleVersionID string) (*ModuleVersion, error)
-	// ReadBySemanticVersion read module version by module and semantic version
-	ReadBySemanticVersion(ctx context.Context, moduleId string, version string) (*ModuleVersion, error)
 }
 
 // moduleVersions implements ModuleVersions.
@@ -105,32 +103,3 @@ func (s *moduleVersions) List(ctx context.Context, options ModuleVersionListOpti
 
 	return mv, nil
 }
-
-func (s *moduleVersions) ReadBySemanticVersion(ctx context.Context, moduleID string, version string) (*ModuleVersion, error) {
-	if !validStringID(&moduleID) {
-		return nil, errors.New("invalid value for module id")
-	}
-
-	v := &version
-	if !validString(v) {
-		return nil, errors.New("invalid value for version")
-	}
-
-	req, err := s.client.newRequest("GET", "module-versions", &ModuleVersionListOptions{Module: moduleID, Version: v})
-	if err != nil {
-		return nil, err
-	}
-
-	mvl := &ModuleVersionList{}
-	err = s.client.do(ctx, req, mvl)
-	if err != nil {
-		return nil, err
-	}
-	if len(mvl.Items) != 1 {
-		return nil, ResourceNotFoundError{
-			Message: fmt.Sprintf("ModuleVersion with Module ID '%v' and version '%v' not found.", moduleID, version),
-		}
-	}
-
-	return mvl.Items[0], nil
-}