Skip to content

Mangadex - Allow www prefix and page suffix #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0x1f595 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Mangadex - Allow www prefix and page suffix #1632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d6fd5e
Mangadex - Allow www prefix and page suffix
0x1f595 Apr 25, 2020
d83a9e0
Adding test case for new Mangadex URL form
0x1f595 Apr 25, 2020
9ad38a9
Merge branch 'main' into mangadex-fixes
metaprime Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/rarchives/ripme/ripper/rippers/MangadexRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ public String getGID(URL url) throws MalformedURLException {
}

private String getChapterID(String url) {
Pattern p = Pattern.compile("https://mangadex.org/chapter/([\\d]+)/([\\d+]?)");
Pattern p = Pattern.compile("https://(www\\.)?mangadex\\.org/chapter/([\\d]+)/([\\d+]?)");
Matcher m = p.matcher(url);
if (m.matches()) {
return m.group(1);
return m.group(3);
}
return null;
}
Expand Down
11 changes: 9 additions & 2 deletions src/test/java/com/rarchives/ripme/tst/ripper/rippers/MangadexRipperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package com.rarchives.ripme.tst.ripper.rippers;


import com.rarchives.ripme.ripper.rippers.MangadexRipper;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;

import org.junit.jupiter.api.Test;

import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
Expand All @@ -19,9 +20,15 @@ public void testRip() throws IOException, URISyntaxException {

@Test
@Tag("flaky")
public void test2() throws IOException, URISyntaxException {
public void testRip2() throws IOException, URISyntaxException {
MangadexRipper ripper = new MangadexRipper(new URI("https://mangadex.org/title/44625/this-croc-will-die-in-100-days").toURL());
testRipper(ripper);
}

@Test
@Tag("flaky")
public void testAltUrlRip() throws IOException, URISyntaxException {
MangadexRipper ripper = new MangadexRipper(new URI("https://www.mangadex.org/chapter/804465/1").toURL());
testRipper(ripper);
}
}
Loading