Incorrect bounds check for externalClientList size validation - checking if size < 0 which is impossible for ArrayList

[sgurivir]

RepoIQ has identified a logical bug in LCSPrivacyClassImpl.java

jss7/map/map-impl/src/main/java/org/restcomm/protocols/ss7/map/service/mobility/subscriberManagement/LCSPrivacyClassImpl.java

Line 204 in 81a54df

if (this.externalClientList.size() < 0 || this.externalClientList.size() > 5)

Title: Potential optimization in _decode in map/map-impl/src/main/java/org/restcomm/protocols/ss7/map/service/mobility/subscriberManagement/LCSPrivacyClassImpl.java

Issue:
LLM based analysis has identified a potential issue.

Incorrect bounds check for externalClientList size validation - checking if size < 0 which is impossible for ArrayList

Impact: The validation logic is incorrect as ArrayList.size() can never be negative, making the lower bound check ineffective

Potential Solution: Change the condition to check if size < 1 instead of size < 0 to properly validate minimum count