Use system font (#69)

Win32 controls default to an old bitmap font for historial purposes.
This isn't the recommended font to use, however.

This commit uses the recommended system font and responds to the user
changing the font.

Author: ProgramMax

Code/maxGUI/ButtonImplementation.cpp

@@ -40,18 +40,7 @@ namespace maxGUI
 
 		Win32String win32_text = Utf8ToWin32String(std::move(text));
 
-		//return CreateWindowEx(0, TEXT("BUTTON"), win32_text.text_, win32_styles, rectangle.TopLeft.X(), rectangle.TopLeft.Y(), rectangle.Width, rectangle.Height, parent_window_handle, NULL, reinterpret_cast<HINSTANCE>(GetWindowLongPtr(parent_window_handle, GWLP_HINSTANCE)), NULL);
-		HWND window_handle = CreateWindowEx(0, TEXT("BUTTON"), win32_text.text_, win32_styles, rectangle.TopLeft.X(), rectangle.TopLeft.Y(), rectangle.Width, rectangle.Height, parent_window_handle, NULL, reinterpret_cast<HINSTANCE>(GetWindowLongPtr(parent_window_handle, GWLP_HINSTANCE)), NULL);
-
-		const int font_height_in_points = 10;
-		HDC screen_device_context = GetDC(NULL);
-		const int font_height_in_logical_units = -MulDiv(font_height_in_points, GetDeviceCaps(screen_device_context, LOGPIXELSY), 72);
-		//const int font_height_in_logical_units = -12;
-		HFONT font = CreateFont(font_height_in_logical_units, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, ANSI_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, FF_DONTCARE | DEFAULT_PITCH, TEXT("Segoe UI"));
-
-		SendMessage(window_handle, WM_SETFONT, reinterpret_cast<WPARAM>(font), TRUE);
-
-		return window_handle;
+		return CreateWindowEx(0, TEXT("BUTTON"), win32_text.text_, win32_styles, rectangle.TopLeft.X(), rectangle.TopLeft.Y(), rectangle.Width, rectangle.Height, parent_window_handle, NULL, reinterpret_cast<HINSTANCE>(GetWindowLongPtr(parent_window_handle, GWLP_HINSTANCE)), NULL);
 	}
 #endif
 

Code/maxGUI/CheckBoxImplementation.cpp

@@ -37,24 +37,7 @@ namespace maxGUI
 		}
 #pragma warning(pop)
 		Win32String win32_text = Utf8ToWin32String(std::move(text));
-		//return CreateWindowEx(0, TEXT("BUTTON"), win32_text.text_, win32_styles, rectangle.TopLeft.X(), rectangle.TopLeft.Y(), rectangle.Width, rectangle.Height, parent_window_handle, NULL, reinterpret_cast<HINSTANCE>(GetWindowLongPtr(parent_window_handle, GWLP_HINSTANCE)), NULL);
-		HWND window_handle = CreateWindowEx(0, TEXT("BUTTON"), win32_text.text_, win32_styles, rectangle.TopLeft.X(), rectangle.TopLeft.Y(), rectangle.Width, rectangle.Height, parent_window_handle, NULL, reinterpret_cast<HINSTANCE>(GetWindowLongPtr(parent_window_handle, GWLP_HINSTANCE)), NULL);
-
-		/*
-		LOGFONT lf;
-		SystemParametersInfo(SPI_GETICONTITLELOGFONT, sizeof(lf), &lf, 0);
-		HFONT font = CreateFontIndirect(&lf);
-		*/
-
-		const int font_height_in_points = 10;
-		HDC screen_device_context = GetDC(NULL);
-		const int font_height_in_logical_units = -MulDiv(font_height_in_points, GetDeviceCaps(screen_device_context, LOGPIXELSY), 72);
-		//const int font_height_in_logical_units = -12;
-		HFONT font = CreateFont(font_height_in_logical_units, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, ANSI_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, FF_DONTCARE | DEFAULT_PITCH, TEXT("Segoe UI"));
-
-		SendMessage(window_handle, WM_SETFONT, reinterpret_cast<WPARAM>(font), TRUE);
-
-		return window_handle;
+		return CreateWindowEx(0, TEXT("BUTTON"), win32_text.text_, win32_styles, rectangle.TopLeft.X(), rectangle.TopLeft.Y(), rectangle.Width, rectangle.Height, parent_window_handle, NULL, reinterpret_cast<HINSTANCE>(GetWindowLongPtr(parent_window_handle, GWLP_HINSTANCE)), NULL);
 	}
 
 	bool CheckBoxImplementation::IsChecked() const noexcept {

Code/maxGUI/Control.cpp

@@ -25,6 +25,27 @@ namespace maxGUI
 #endif
 	}
 
+	void Control::NewSystemFont() noexcept {
+#if defined(MAX_PLATFORM_WINDOWS)
+		// Win32 way
+		LOGFONT lf = {0};
+		SystemParametersInfo(SPI_GETICONTITLELOGFONT, sizeof(lf), &lf, 0);
+		HFONT font = CreateFontIndirect(&lf);
+		SendMessage(window_handle_, WM_SETFONT, reinterpret_cast<WPARAM>(font), TRUE);
+
+		// WinUI way
+		/*
+		//const int font_height_in_points = 10; // 14
+		//HDC screen_device_context = GetDC(NULL);
+		//const int font_height_in_logical_units = -MulDiv(font_height_in_points, GetDeviceCaps(screen_device_context, LOGPIXELSY), 72);
+		const int font_height_in_logical_units = -14; // -12
+		// Shouldn't it be "Segoe UI Variable"? Why does that look wrong?
+		HFONT font = CreateFont(font_height_in_logical_units, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, ANSI_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, FF_DONTCARE | DEFAULT_PITCH, TEXT("Segoe UI"));
+		SendMessage(window_handle_, WM_SETFONT, reinterpret_cast<WPARAM>(font), TRUE);
+		*/
+#endif
+	}
+
 #if defined(MAX_PLATFORM_WINDOWS)
 	void Control::OnCommand(WORD /*notification*/) noexcept
 	{}

Code/maxGUI/Control.hpp

@@ -73,6 +73,8 @@ namespace maxGUI
 
 	//protected:
 
+		void NewSystemFont() noexcept;
+
 #if defined(MAX_PLATFORM_WINDOWS)
 		virtual void OnCommand(WORD notification) noexcept;
 #endif

Code/maxGUI/FormConcept.cpp

@@ -6,7 +6,6 @@
 
 #include <utility>
 
-
 namespace maxGUI {
 
 	#if defined(MAX_PLATFORM_WINDOWS)

Code/maxGUI/FormConcept.hpp

@@ -53,6 +53,7 @@ namespace maxGUI
 			auto* widget = T::Create(&window_, std::forward<Params>(params)...);
 			auto control_ptr = std::make_unique<T>(std::move(widget));
 #endif
+			control_ptr->NewSystemFont();
 			T* raw_control_ptr = control_ptr.get();
 			controls_.push_back(std::move(control_ptr));
 #if defined(MAX_PLATFORM_LINUX)

Code/maxGUI/FormContainer.cpp

@@ -117,6 +117,15 @@ namespace maxGUI {
 				}
 			}
 			return 0;
+			case WM_SETTINGCHANGE:
+			{
+				// new font settings possible
+				auto form = GetFormFromHWND(window_handle);
+				for (auto& control : form->controls_) {
+					control->NewSystemFont();
+				}
+			}
+			return 0;
 			}
 
 			auto form = GetFormFromHWND(window_handle);

Code/maxGUI/RadioButtonImplementation.cpp

@@ -40,26 +40,7 @@ namespace maxGUI
 		}
 #pragma warning(pop)
 		Win32String win32_text = Utf8ToWin32String(std::move(text));
-		//return CreateWindowEx(0, TEXT("BUTTON"), win32_text.text_, win32_styles, rectangle.TopLeft.X(), rectangle.TopLeft.Y(), rectangle.Width, rectangle.Height, parent_window_handle, NULL, reinterpret_cast<HINSTANCE>(GetWindowLongPtr(parent_window_handle, GWLP_HINSTANCE)), NULL);
-		HWND window_handle = CreateWindowEx(0, TEXT("BUTTON"), win32_text.text_, win32_styles, rectangle.TopLeft.X(), rectangle.TopLeft.Y(), rectangle.Width, rectangle.Height, parent_window_handle, NULL, reinterpret_cast<HINSTANCE>(GetWindowLongPtr(parent_window_handle, GWLP_HINSTANCE)), NULL);
-
-		static int count = 0;
-		if (count == 0) {
-			LOGFONT lf = {0};
-			SystemParametersInfo(SPI_GETICONTITLELOGFONT, sizeof(lf), &lf, 0);
-			HFONT font = CreateFontIndirect(&lf);
-			SendMessage(window_handle, WM_SETFONT, reinterpret_cast<WPARAM>(font), TRUE);
-		} else {
-			//const int font_height_in_points = 14;
-			//HDC screen_device_context = GetDC(NULL);
-			//const int font_height_in_logical_units = -MulDiv(font_height_in_points, GetDeviceCaps(screen_device_context, LOGPIXELSY), 72);
-			const int font_height_in_logical_units = -14;
-			HFONT font = CreateFont(font_height_in_logical_units, 0, 0, 0, FW_DONTCARE, FALSE, FALSE, FALSE, ANSI_CHARSET, OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, FF_DONTCARE | DEFAULT_PITCH, TEXT("Segoe UI Variable"));
-			SendMessage(window_handle, WM_SETFONT, reinterpret_cast<WPARAM>(font), TRUE);
-		}
-		count++;
-
-		return window_handle;
+		return CreateWindowEx(0, TEXT("BUTTON"), win32_text.text_, win32_styles, rectangle.TopLeft.X(), rectangle.TopLeft.Y(), rectangle.Width, rectangle.Height, parent_window_handle, NULL, reinterpret_cast<HINSTANCE>(GetWindowLongPtr(parent_window_handle, GWLP_HINSTANCE)), NULL);
 	}
 #endif