TASK: Add test for BinaryOperationTypeResolver in case a semantically wrong arithmetic operation is given

Author: grebaldi

test/Unit/TypeSystem/Resolver/BinaryOperation/BinaryOperationTypeResolverTest.php

@@ -90,4 +90,46 @@ public function resolvesBinaryOperationToResultingType(string $binaryOperationAs
             sprintf('Expected %s, got %s', $expectedType::class, $actualType::class)
         );
     }
+
+
+    /**
+     * @return array<string,mixed>
+     */
+    public static function faultyArithmeticOperationExamples(): array
+    {
+        return [
+            '1 + false' => ['1 + false'],
+            '1 + "foo"' => ['1 + "foo"'],
+            '1 + null' => ['1 + null'],
+            '1 + <img/>' => ['1 + <img/>'],
+            'true + 1' => ['true + 1'],
+            '"bar" + 1' => ['"bar" + 1'],
+            'null + 1' => ['null + 1'],
+            '<input/> + 1' => ['<input/> + 1'],
+            'true + false' => ['true + false'],
+            'true + null' => ['true + null'],
+            'null + "foobar"' => ['null + "foobar"'],
+            '"foobar" + <link rel="barfoo"/>' => ['"foobar" + <link rel="barfoo"/>'],
+        ];
+    }
+
+    /**
+     * @dataProvider faultyArithmeticOperationExamples
+     * @test
+     * @param string $faultyArithmeticOperationAsString
+     * @return void
+     */
+    public function throwsIfBinaryOperationIsArithmeticButOperandsAreNotOfTypeNumber(string $faultyArithmeticOperationAsString): void
+    {
+        $scope = new DummyScope();
+        $binaryOperationTypeResolver = new BinaryOperationTypeResolver(
+            scope: $scope
+        );
+        $arithmeticOperationNode = ExpressionNode::fromString($faultyArithmeticOperationAsString)->root;
+        assert($arithmeticOperationNode instanceof BinaryOperationNode);
+
+        $this->expectExceptionMessageMatches('/number/i');
+
+        $binaryOperationTypeResolver->resolveTypeOf($arithmeticOperationNode);
+    }
 }