TASK: Add test cases for complex bracketed expressions

Author: grebaldi

scripts/test

@@ -14,6 +14,9 @@
 
 ./vendor/bin/phpunit \
     --enforce-time-limit \
+    --display-deprecations \
+    --display-errors \
+    --display-notices \
     --testdox \
     --coverage-html build/coverage-report \
     --coverage-filter src $@

test/Unit/Language/Parser/Expression/ExpressionParserTest.php

@@ -1362,6 +1362,7 @@ public function parsesNestedBracketedTernaryOperation(): void
             $expressionParser->parse($tokens)
         );
     }
+
     /**
      * @test
      */
@@ -1436,6 +1437,62 @@ public function parsesNestedUnbracketedTernaryOperation(): void
         );
     }
 
+    /**
+     * @test
+     */
+    public function parsesTernaryOperationWithComplexParentheses(): void
+    {
+        $expressionParser = new ExpressionParser();
+        $tokens = $this->createTokenIterator('(((foo)) === ((null))) ? 1 : (((0)))');
+
+        $expectedExpressioNode = new ExpressionNode(
+            rangeInSource: $this->range([0, 0], [0, 35]),
+            root: new TernaryOperationNode(
+                condition: new ExpressionNode(
+                    rangeInSource: $this->range([0, 0], [0, 21]),
+                    root: new BinaryOperationNode(
+                        rangeInSource: $this->range([0, 1], [0, 20]),
+                        leftOperand: new ExpressionNode(
+                            rangeInSource: $this->range([0, 1], [0, 7]),
+                            root: new ValueReferenceNode(
+                                rangeInSource: $this->range([0, 3], [0, 5]),
+                                name: VariableName::from('foo')
+                            )
+                        ),
+                        operator: BinaryOperator::EQUAL,
+                        rightOperand: new ExpressionNode(
+                            rangeInSource: $this->range([0, 13], [0, 20]),
+                            root: new NullLiteralNode(
+                                rangeInSource: $this->range([0, 15], [0, 18])
+                            )
+                        ),
+                    )
+                ),
+                trueBranch: new ExpressionNode(
+                    rangeInSource: $this->range([0, 25], [0, 25]),
+                    root: new IntegerLiteralNode(
+                        rangeInSource: $this->range([0, 25], [0, 25]),
+                        format: IntegerFormat::DECIMAL,
+                        value: '1'
+                    )
+                ),
+                falseBranch: new ExpressionNode(
+                    rangeInSource: $this->range([0, 29], [0, 35]),
+                    root: new IntegerLiteralNode(
+                        rangeInSource: $this->range([0, 32], [0, 32]),
+                        format: IntegerFormat::DECIMAL,
+                        value: '0'
+                    ),
+                )
+            )
+        );
+
+        $this->assertEquals(
+            $expectedExpressioNode,
+            $expressionParser->parse($tokens)
+        );
+    }
+
     /**
      * @test
      */
@@ -1608,4 +1665,48 @@ public function parsesValueReference(): void
             $expressionParser->parse($tokens)
         );
     }
+
+    /**
+     * @test
+     */
+    public function parsesMultipleParenthesesAroundValureReferenceCorrecly(): void
+    {
+        $expressionParser = new ExpressionParser();
+
+        $tokens = $this->createTokenIterator('(foo)');
+        $this->assertEquals(
+            new ExpressionNode(
+                rangeInSource: $this->range([0, 0], [0, 4]),
+                root: new ValueReferenceNode(
+                    rangeInSource: $this->range([0, 1], [0, 3]),
+                    name: VariableName::from('foo')
+                )
+            ),
+            $expressionParser->parse($tokens)
+        );
+
+        $tokens = $this->createTokenIterator('((foo))');
+        $this->assertEquals(
+            new ExpressionNode(
+                rangeInSource: $this->range([0, 0], [0, 6]),
+                root: new ValueReferenceNode(
+                    rangeInSource: $this->range([0, 2], [0, 4]),
+                    name: VariableName::from('foo')
+                )
+            ),
+            $expressionParser->parse($tokens)
+        );
+
+        $tokens = $this->createTokenIterator('(((foo)))');
+        $this->assertEquals(
+            new ExpressionNode(
+                rangeInSource: $this->range([0, 0], [0, 8]),
+                root: new ValueReferenceNode(
+                    rangeInSource: $this->range([0, 3], [0, 5]),
+                    name: VariableName::from('foo')
+                )
+            ),
+            $expressionParser->parse($tokens)
+        );
+    }
 }