Fix test case and check for a single process/worker

Author: jyeshe

test/lightning/distributed_rate_limiter_test.exs

@@ -40,18 +40,16 @@ defmodule Lightning.DistributedRateLimiterTest do
       assert {:allow, level} = DistributedRateLimiter.check_rate(bucket2)
       assert level == initial_capacity - 1
 
-      assert {:deny, wait_ms} = DistributedRateLimiter.check_rate(bucket1) |> dbg
+      assert {:deny, wait_ms} = DistributedRateLimiter.check_rate(bucket1)
       assert 500 < wait_ms and wait_ms <= 1_000
     end
 
-    # Synthetic cluster not working.
-    # For testing use manual procedure:
+    # For testing the replication use manual procedure:
     # 0. Disable Endpoint server
     # 1. Run node1 on one terminal: iex --sname node1@localhost --cookie hordecookie -S mix phx.server
     # 2. Run node2 on another terminal: iex --sname node2@localhost --cookie hordecookie -S mix phx.server
     # 3. Call Lightning.DistributedRateLimiter.inspect_table() on both iex and they show the same ets table process and node.
-    @tag skip: true
-    test "consumes the bucket remotely" do
+    test "works on top of a single worker of a distributed dynamic supervisor" do
       {:ok, peer, _node1, node2} = start_nodes(:node1, :node2, ~c"localhost")
 
       :rpc.call(node2, Application, :ensure_all_started, [:mix])
@@ -65,21 +63,10 @@ defmodule Lightning.DistributedRateLimiterTest do
                {Lightning.DistributedSupervisor, :node2@localhost}
              ] = Horde.Cluster.members(Lightning.DistributedSupervisor)
 
-      # initial_capacity = @default_capacity
-      bucket = "project#{System.unique_integer()}"
-
-      dbg(DistributedRateLimiter.check_rate(bucket))
-
-      # dbg :rpc.block_call(node1, DistributedRateLimiter, :inspect, [DistributedRateLimiter])
-      # dbg :rpc.block_call(node2, DistributedRateLimiter, :inspect, [DistributedRateLimiter])
-
-      # Enum.each(1..initial_capacity-1, fn i ->
-      #   assert {:allow, level} = :rpc.call(node2, DistributedRateLimiter, :check_rate, [bucket, 1])
-      #   assert level == initial_capacity - i - 1
-      # end)
-
-      # assert {:deny, wait_ms} = DistributedRateLimiter.check_rate(bucket)
-      # assert 0 < wait_ms and wait_ms < 1_000
+      assert [{:undefined, _pid, :worker, [Lightning.DistributedRateLimiter]}] =
+               Horde.DynamicSupervisor.which_children(
+                 Lightning.DistributedSupervisor
+               )
 
       :peer.stop(peer)
     end