Skip to content

feat(scanner): depWalker add stats on tarball.scanDirOrArchive #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fraxken merged 1 commit into from
Jan 28, 2026
Merged

feat(scanner): depWalker add stats on tarball.scanDirOrArchive #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cute-ghosts-rescue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nodesecure/scanner": minor
---

feat(scanner): depWalker add stats on tarball.scanDirOrArchive
15 changes: 10 additions & 5 deletions workspaces/scanner/src/depWalker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,8 @@ export async function depWalker(
ref: dependency.versions[version] as any,
location,
isRootNode: scanRootNode && name === manifest.name,
registry
registry,
statsCollector
};
operationsQueue.push(
scanDirOrArchiveEx(name, version, locker, tempDir, logger, scanDirOptions)
Expand Down Expand Up @@ -392,31 +393,35 @@ async function scanDirOrArchiveEx(
isRootNode: boolean;
location: string | undefined;
ref: any;
statsCollector: StatsCollector;
}
) {
using _ = await locker.acquire();

const spec = `${name}@${version}`;

try {
const {
registry,
location = process.cwd(),
isRootNode,
ref
ref,
statsCollector
} = options;

const mama = await (isRootNode ?
ManifestManager.fromPackageJSON(location) :
extractAndResolve(tempDir.location, {
spec: `${name}@${version}`,
spec,
registry
})
);

await scanDirOrArchive(mama, ref, {
await statsCollector.track(`tarball.scanDirOrArchive ${spec}`, () => scanDirOrArchive(mama, ref, {
astAnalyserOptions: {
optionalWarnings: typeof location !== "undefined"
}
});
}));
}
catch (error: any) {
logger.emit(ScannerLoggerEvents.error, error, "tarball-scan");
Expand Down
2 changes: 1 addition & 1 deletion workspaces/scanner/test/depWalker.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ test("execute depWalker on pkg.gitdeps", async(test) => {
assert.strictEqual(typeof metadata.startedAt, "number");
assert.strictEqual(typeof metadata.executionTime, "number");
assert.strictEqual(Array.isArray(metadata.apiCalls), true);
assert.strictEqual(metadata.apiCallsCount, 25);
assert.strictEqual(metadata.apiCallsCount, 37);
});

test("execute depWalker on typo-squatting (with location)", async(test) => {
Expand Down