Skip to content

Added support for sunion and sinter #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balajivenki wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Added support for sunion and sinter #147

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
36ecc8c
Added support for sunion and sinter
balajivenki Oct 19, 2016
0490711
Merge branch 'master' into master
balajivenki Oct 19, 2016
90e9806
Merge remote-tracking branch 'Netflix/master'
balajivenki Oct 19, 2016
018d76c
Merge branch 'master' of https://github.com/balajivenki/dyno
balajivenki Oct 19, 2016
e8ac130
Merge branch 'master' into master
ipapapa Oct 24, 2016
09652dc
Merge branch 'master' into master
balajivenki Oct 27, 2016
157319f
Merge branch 'master' into master
balajivenki Nov 7, 2016
9ec4d40
Merge remote-tracking branch 'Netflix/master'
balajivenki Jan 27, 2017
f857bdc
Merge remote-tracking branch 'origin/master'
balajivenki Jan 27, 2017
5333e19
Merge branch 'master' into master
ipapapa Jun 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions dyno-jedis/src/main/java/com/netflix/dyno/jedis/DynoJedisClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
******************************************************************************/
package com.netflix.dyno.jedis;

import com.google.common.collect.Sets;
import com.netflix.discovery.DiscoveryClient;
import com.netflix.discovery.EurekaClient;
import com.netflix.dyno.connectionpool.*;
Expand All @@ -26,12 +27,13 @@
import com.netflix.dyno.connectionpool.impl.lb.HttpEndpointBasedTokenMapSupplier;
import com.netflix.dyno.connectionpool.impl.utils.CollectionUtils;
import com.netflix.dyno.connectionpool.impl.utils.ZipUtils;
import com.netflix.dyno.contrib.*;

import com.netflix.dyno.contrib.ArchaiusConnectionPoolConfiguration;
import com.netflix.dyno.contrib.DynoCPMonitor;
import com.netflix.dyno.contrib.DynoOPMonitor;
import com.netflix.dyno.contrib.EurekaHostsSupplier;
import org.slf4j.Logger;

import redis.clients.jedis.BinaryClient.LIST_POSITION;
import redis.clients.jedis.*;
import redis.clients.jedis.BinaryClient.LIST_POSITION;
import redis.clients.jedis.params.geo.GeoRadiusParam;
import redis.clients.jedis.params.sortedset.ZAddParams;
import redis.clients.jedis.params.sortedset.ZIncrByParams;
Expand Down Expand Up @@ -2593,7 +2595,13 @@ public Long msetnx(String... keysvalues) {

@Override
public Set<String> sinter(String... keys) {
throw new UnsupportedOperationException("not yet implemented");
Set<String> allResults = d_smembers(keys[0]).getResult();
Copy link
Contributor Author

@balajivenki balajivenki Oct 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assign the global set with the first keys smembers.

//loop through keys and intersect to a set, use d_smembers
for(int i = 1; i < keys.length; i++) {
allResults = Sets.intersection(allResults, d_smembers(keys[i]).getResult());
Copy link
Contributor Author

@balajivenki balajivenki Oct 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Guava set intersection.

}

return allResults;
}

public Long sinterstore(final String dstkey, final String... keys) {
Expand All @@ -2612,7 +2620,14 @@ public Long sort(String key, String dstkey) {

@Override
public Set<String> sunion(String... keys) {
throw new UnsupportedOperationException("not yet implemented");
Set<String> allResults = new HashSet<String>();
Copy link
Contributor Author

@balajivenki balajivenki Oct 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just get all the smembers and push it to a single set.

//loop through keys and append to a set, use d_smembers
for(String key : keys) {
OperationResult<Set<String>> results = d_smembers(key);
allResults.addAll(results.getResult());
}

return allResults;
}

@Override
Expand Down