Skip to content

Commit 73a738f

Browse files
committed
replace chrono::steady_clock usage with chrono::system_clock for profiling
1 parent ff813e3 commit 73a738f

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

test-app/runtime/src/main/cpp/CallbackHandlers.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -634,8 +634,8 @@ void CallbackHandlers::LogMethodCallback(const v8::FunctionCallbackInfo<v8::Valu
634634
}
635635

636636
void CallbackHandlers::TimeCallback(const v8::FunctionCallbackInfo<v8::Value>& args) {
637-
auto nano = std::chrono::time_point_cast<std::chrono::nanoseconds>(std::chrono::steady_clock::now());
638-
double duration = nano.time_since_epoch().count() / 1000000.0;
637+
auto nano = std::chrono::time_point_cast<std::chrono::milliseconds>(std::chrono::system_clock::now());
638+
double duration = nano.time_since_epoch().count();
639639
args.GetReturnValue().Set(duration);
640640
}
641641

test-app/runtime/src/main/cpp/ManualInstrumentation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
#include "ManualInstrumentation.h"
66

77
bool tns::instrumentation::Frame::disabled = true;
8-
const std::chrono::steady_clock::time_point tns::instrumentation::Frame::disabled_time = std::chrono::steady_clock::time_point();
8+
const std::chrono::system_clock::time_point tns::instrumentation::Frame::disabled_time = std::chrono::system_clock::time_point();

test-app/runtime/src/main/cpp/ManualInstrumentation.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ namespace instrumentation {
1515
class Frame {
1616
public:
1717
inline Frame() : Frame("") { }
18-
inline Frame(std::string name) : name(name), start(disabled ? disabled_time : std::chrono::steady_clock::now()) {}
18+
inline Frame(std::string name) : name(name), start(disabled ? disabled_time : std::chrono::system_clock::now()) {}
1919

2020
inline ~Frame() {
2121
if (!name.empty() && check()) {
@@ -27,7 +27,7 @@ class Frame {
2727
if (disabled) {
2828
return false;
2929
}
30-
std::chrono::steady_clock::time_point end = std::chrono::steady_clock::now();
30+
std::chrono::system_clock::time_point end = std::chrono::system_clock::now();
3131
auto duration = std::chrono::duration_cast<std::chrono::microseconds>(std::chrono::operator-(end, start)).count();
3232
return duration >= 16000;
3333
}
@@ -36,7 +36,7 @@ class Frame {
3636
if (disabled) {
3737
return;
3838
}
39-
std::chrono::steady_clock::time_point end = std::chrono::steady_clock::now();
39+
std::chrono::system_clock::time_point end = std::chrono::system_clock::now();
4040
auto duration = std::chrono::duration_cast<std::chrono::microseconds>(std::chrono::operator-(end, start)).count();
4141
auto startMilis = std::chrono::time_point_cast<std::chrono::microseconds>(start).time_since_epoch().count() / 1000.0;
4242
auto endMilis = std::chrono::time_point_cast<std::chrono::microseconds>(end).time_since_epoch().count() / 1000.0;
@@ -56,9 +56,9 @@ class Frame {
5656

5757
private:
5858
static bool disabled;
59-
static const std::chrono::steady_clock::time_point disabled_time; // Couldn't find reasonable constant
59+
static const std::chrono::system_clock::time_point disabled_time; // Couldn't find reasonable constant
6060

61-
const std::chrono::steady_clock::time_point start;
61+
const std::chrono::system_clock::time_point start;
6262
const std::string name;
6363

6464
Frame(const Frame&) = delete;

0 commit comments

Comments
 (0)