Skip to content

Commit 2841f17

Browse files
committed
Revert "Revert "Upgrade v8 to 6.8.275.26""
This reverts commit 899afff.
1 parent d6ff22f commit 2841f17

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+3081
-2287
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"v8Version": "6.7.288.46"
2+
"v8Version": "6.8.275.26"
33
}
-982 KB
Binary file not shown.
-1.34 MB
Binary file not shown.
-1.14 MB
Binary file not shown.

test-app/runtime/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,12 +179,12 @@ MESSAGE( STATUS "# CMAKE_CXX_FLAGS: " ${CMAKE_CXX_FLAGS} )
179179
# linking v8 and inspector libraries to runtime(NativeScript library)
180180
target_link_libraries( NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libzip.a )
181181
target_link_libraries( NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libv8_base.a )
182+
target_link_libraries( NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libv8_snapshot.a )
182183
target_link_libraries( NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libv8_init.a )
183184
target_link_libraries( NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libv8_initializers.a )
184185
target_link_libraries( NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libv8_libplatform.a )
185186
target_link_libraries( NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libv8_libsampler.a )
186187
target_link_libraries( NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libv8_libbase.a )
187-
target_link_libraries( NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID_ABI}/libv8_snapshot.a )
188188

189189
# Command info: https://cmake.org/cmake/help/v3.4/command/find_library.html
190190
# Searches for a specified prebuilt library and stores the path as a
@@ -195,7 +195,6 @@ target_link_libraries( NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROI
195195
find_library( system-log log )
196196
find_library( system-android android )
197197
find_library( system-dl dl )
198-
find_library( system-atomic atomic ) # TODO: plamen5kov: can't be found in ndk for some reasong ... look at it later (maybe deprecated in newer NDK versions)
199198
find_library( system-z z )
200199

201200
# Command info: https://cmake.org/cmake/help/v3.4/command/target_link_libraries.html

test-app/runtime/src/main/cpp/Profiler.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,12 @@ void Profiler::StopCPUProfilerCallbackImpl(const v8::FunctionCallbackInfo<v8::Va
8282
}
8383

8484
void Profiler::StartCPUProfiler(Isolate* isolate, const Local<String>& name) {
85-
auto v8prof = isolate->GetCpuProfiler();
85+
auto v8prof = CpuProfiler::New(isolate);
8686
v8prof->StartProfiling(name, true);
8787
}
8888

8989
bool Profiler::StopCPUProfiler(Isolate* isolate, const Local<String>& name) {
90-
auto v8prof = isolate->GetCpuProfiler();
90+
auto v8prof = CpuProfiler::New(isolate);
9191
auto cpuProfile = v8prof->StopProfiling(name);
9292

9393
auto success = false;

test-app/runtime/src/main/cpp/include/libplatform/libplatform.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ V8_PLATFORM_EXPORT bool PumpMessageLoop(
6262
v8::Platform* platform, v8::Isolate* isolate,
6363
MessageLoopBehavior behavior = MessageLoopBehavior::kDoNotWait);
6464

65-
V8_PLATFORM_EXPORT V8_DEPRECATE_SOON(
65+
V8_PLATFORM_EXPORT V8_DEPRECATED(
6666
"This function has become obsolete and is essentially a nop",
6767
void EnsureEventLoopInitialized(v8::Platform* platform,
6868
v8::Isolate* isolate));

0 commit comments

Comments
 (0)