From a20bed87e6911901f7126ff6610397b18b7b5e2f Mon Sep 17 00:00:00 2001 From: tgasser-nv <200644301+tgasser-nv@users.noreply.github.com> Date: Thu, 11 Dec 2025 18:50:36 +0000 Subject: [PATCH 1/2] Use temporary path as default value in AIperf tests --- nemoguardrails/llm/providers/huggingface/streamers.py | 4 ++-- tests/benchmark/test_run_aiperf.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/nemoguardrails/llm/providers/huggingface/streamers.py b/nemoguardrails/llm/providers/huggingface/streamers.py index 14c406124..4afb44ac4 100644 --- a/nemoguardrails/llm/providers/huggingface/streamers.py +++ b/nemoguardrails/llm/providers/huggingface/streamers.py @@ -18,8 +18,8 @@ TRANSFORMERS_AVAILABLE = True try: - from transformers.generation.streamers import ( # type: ignore[import-untyped] - TextStreamer, + from transformers.generation.streamers import ( + TextStreamer, # type: ignore[import-untyped] ) except ImportError: # Fallback if transformers is not available diff --git a/tests/benchmark/test_run_aiperf.py b/tests/benchmark/test_run_aiperf.py index 3ee4f1f5b..44c131e42 100644 --- a/tests/benchmark/test_run_aiperf.py +++ b/tests/benchmark/test_run_aiperf.py @@ -34,13 +34,13 @@ @pytest.fixture -def create_config_data(): +def create_config_data(tmp_path): """Returns a function with sample basic config, and allows mutation of fields to cover more cases or add extra fields""" def _create_config( batch_name="test_batch", - output_base_dir="test_output", + output_base_dir=str(tmp_path), model="test-model", tokenizer="test-tokenizer", url="http://localhost:8000", @@ -125,7 +125,7 @@ def test_init_with_valid_config(self, create_config_file): assert runner.config_path == config_file assert isinstance(runner.config, AIPerfConfig) assert runner.config.batch_name == "test_batch" - assert runner.config.output_base_dir == "test_output" + assert runner.config.output_base_dir == str(config_file.parent) assert runner.config.base_config.model == "test-model" assert runner.config.base_config.tokenizer == "test-tokenizer" assert runner.config.base_config.url == "http://localhost:8000" From bed648097689049f75c5035f6239e1a740b7b70b Mon Sep 17 00:00:00 2001 From: tgasser-nv <200644301+tgasser-nv@users.noreply.github.com> Date: Thu, 11 Dec 2025 19:16:24 +0000 Subject: [PATCH 2/2] Revert type fix that's needed locally but breaks on the server --- nemoguardrails/llm/providers/huggingface/streamers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nemoguardrails/llm/providers/huggingface/streamers.py b/nemoguardrails/llm/providers/huggingface/streamers.py index 4afb44ac4..14c406124 100644 --- a/nemoguardrails/llm/providers/huggingface/streamers.py +++ b/nemoguardrails/llm/providers/huggingface/streamers.py @@ -18,8 +18,8 @@ TRANSFORMERS_AVAILABLE = True try: - from transformers.generation.streamers import ( - TextStreamer, # type: ignore[import-untyped] + from transformers.generation.streamers import ( # type: ignore[import-untyped] + TextStreamer, ) except ImportError: # Fallback if transformers is not available