Skip to content

Commit 020c386

Browse files
authored
syrk! and herk! are in the BLAS module (#94)
- need to use the qualified names `BLAS.syrk!` and `BLAS.herk!` - a large block of code is inside `if VERSION < v"1.3.0-alpha.115` but `Project.toml` gives the minimum Julia version as 1.6 I think that block should be dropped but I don't know what your policy regarding dropping dead code is.
1 parent d16065d commit 020c386

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/juliaBLAS.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ Base.@deprecate rankUpdate!(α::Real, a::StridedVector, A::Hermitian) rankUpdate
4949

5050
# Rank k update
5151
## Real
52-
rankUpdate!(C::HermOrSym{T,S}, A::StridedMatrix{T}, α::T, β::T) where {T<:BlasReal,S<:StridedMatrix} = syrk!(C.uplo, 'N', α, A, β, C.data)
52+
rankUpdate!(C::HermOrSym{T,S}, A::StridedMatrix{T}, α::T, β::T) where {T<:BlasReal,S<:StridedMatrix} = BLAS.syrk!(C.uplo, 'N', α, A, β, C.data)
5353

5454
## Complex
55-
rankUpdate!(C::Hermitian{T,S}, A::StridedMatrix{Complex{T}}, α::T, β::T) where {T<:BlasReal,S<:StridedMatrix} = herk!(C.uplo, 'N', α, A, β, C.data)
55+
rankUpdate!(C::Hermitian{T,S}, A::StridedMatrix{Complex{T}}, α::T, β::T) where {T<:BlasReal,S<:StridedMatrix} = BLAS.herk!(C.uplo, 'N', α, A, β, C.data)
5656

5757
### Generic
5858
function rankUpdate!(C::Hermitian, A::StridedVecOrMat, α::Real)
@@ -84,7 +84,7 @@ end
8484
Base.@deprecate rankUpdate!::Real, A::StridedVecOrMat, C::Hermitian) rankUpdate!(C, A, α)
8585
Base.@deprecate rankUpdate!::Real, A::StridedVecOrMat, β::Real, C::Hermitian) rankUpdate!(C, A, α, β)
8686

87-
if VERSION < v"1.3.0-alpha.115"
87+
if VERSION < v"1.3.0-alpha.115" # Project.toml has julia = "1.6" so this block should no longer be necessary
8888
# BLAS style mul!
8989
## gemv
9090
mul!(y::StridedVector{T}, A::StridedMatrix{T}, x::StridedVector{T}, α::T, β::T) where {T<:BlasFloat} = gemv!('N', α, A, x, β, y)

0 commit comments

Comments
 (0)